Date: Thu, 22 Feb 2007 09:55:43 -0800 From: Luigi Rizzo <rizzo@icir.org> To: Jeremy Messenger <mezz7@cox.net> Cc: multimedia@freebsd.org Subject: Re: speex upgrade to 1.1.12 ? Message-ID: <20070222095543.A7555@xorpc.icir.org> In-Reply-To: <op.tn5vkdeh9aq2h7@mezz.mezzweb.com>; from mezz7@cox.net on Thu, Feb 22, 2007 at 11:44:27AM -0600 References: <20070221073447.A89386@xorpc.icir.org> <op.tn31gkon9aq2h7@mezz.mezzweb.com> <20070221095911.D90766@xorpc.icir.org> <op.tn34fuds9aq2h7@mezz.mezzweb.com> <20070221112414.E91427@xorpc.icir.org> <op.tn372ibm9aq2h7@mezz.mezzweb.com> <op.tn4hkoua9aq2h7@mezz.mezzweb.com> <20070221160312.A94968@xorpc.icir.org> <op.tn5vkdeh9aq2h7@mezz.mezzweb.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 22, 2007 at 11:44:27AM -0600, Jeremy Messenger wrote: ... > > http://info.iet.unipi.it/~luigi/FreeBSD/speex-devel-20070221.tgz > > Why remove two patches? They are not need anymore? I can build with two apparently yes they are not needed anymore. > patches w/out any of problem. As for the Makefile, I have done a bit tweak > from your changes. Example: > -PORTVERSION -> DISTVERSION. > -CONFLICTS=speex-*, this is incorrect and is too general. It should be > speex-[0-9]*. > -Remove 'devel version' and peroid. An end of peroid in the sentence is > illegal in COMMENT. > -INSTALLS_SHLIB -> USE_LDCONFIG. > -CONFIGURE_TARGET -> USE_GNOME=gnometarget > -Add USE_GNOME=ltverhack to avoid shared library version bump to often by > fix libtool bug. > -Add CONFIGURE_ENV by add -I/-L${LOCALBASE}/[...] to make it works when > install speex in the different prefix. fine, most of the things you note below were just inherited from the previous one (PORTVERSION, CONFIGURE_TARGET, INSTALL_SHLIBS). > -Remove MAKE_ENV, I don't think it is need. LDFLAGS was added because some of the code uses the math library and -lm is not included by default on my box at least (RELENG_6). Maybe some of the other changes you made also imply -lm ? CFLAGS were just added to build with stricter compiler flags, so it is not strictly necessary; > > I am not done (have to go back to class soon) with it yet, so if you have > any of question then let me know. nothing else. cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070222095543.A7555>