Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 01 Feb 2003 14:16:49 +0100
From:      phk@freebsd.org
To:        Jon Mini <mini@freebsd.org>
Cc:        Julian Elischer <julian@elischer.org>, "M. Warner Losh" <imp@bsdimp.com>, jhb@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org, tjr@freebsd.org
Subject:   Re: cvs commit: src/sys/kern subr_trap.c 
Message-ID:  <17970.1044105409@critter.freebsd.dk>
In-Reply-To: Your message of "Sat, 01 Feb 2003 04:37:28 PST." <20030201123728.GV27470@elvis.mu.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20030201123728.GV27470@elvis.mu.org>, Jon Mini writes:
>phk@freebsd.org [phk@freebsd.org] wrote :
>
>> Well, considering that you have to:
>> 
>> 	Generate backout patch.
>> 	Test it on at least:
>> 		i386/UP
>> 		i386/SMP
>> 		alpha/UP
>> 		alpha/SMP
>> 		sparc64 (has no UP/SMP split)
>> 	Commit it.
>
>Woah.. 
>We need to test backouts?
>
>Doesn't that seem a bit extreme?

A backout is no less a commit than a normal commit.  Considering that
Julian har probably barely seen the patch he is now backing out, I
would think that a normal test would be the minimum he should do.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17970.1044105409>