Date: Thu, 24 May 2018 18:59:57 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r470615 - head Message-ID: <fu2h-6lbm-wny@FreeBSD.org> In-Reply-To: <20180524181330.001bd99e@kalimero.tijl.coosemans.org> (Tijl Coosemans's message of "Thu, 24 May 2018 18:13:30 %2B0200") References: <201805221358.w4MDwYtl021212@repo.freebsd.org> <20180522160246.239217d9@kalimero.tijl.coosemans.org> <20180524124550.wxsfet7qts3zevq7@ogg.in.absolight.net> <20180524145450.3345318f@kalimero.tijl.coosemans.org> <20180524143752.7vpfnzfxwkczi6h3@ogg.in.absolight.net> <20180524181330.001bd99e@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Tijl Coosemans <tijl@FreeBSD.org> writes:
> On Thu, 24 May 2018 16:37:52 +0200 Mathieu Arnold <mat@FreeBSD.org> wrote:
>
>> On Thu, May 24, 2018 at 02:54:50PM +0200, Tijl Coosemans wrote:
>>> On Thu, 24 May 2018 14:45:50 +0200 Mathieu Arnold <mat@FreeBSD.org> wrote:
>>>> On Tue, May 22, 2018 at 04:02:46PM +0200, Tijl Coosemans wrote:
>>>>> On Tue, 22 May 2018 13:58:34 +0000 (UTC) Mathieu Arnold <mat@FreeBSD.org> wrote:
>>>>>> --- head/CHANGES Tue May 22 13:58:03 2018 (r470614)
>>>>>> +++ head/CHANGES Tue May 22 13:58:33 2018 (r470615)
>>>>>> @@ -152,8 +152,7 @@ AUTHOR: mat@FreeBSD.org
>>>>>>
>>>>>> In all the ports with Python dependencies, the *_DEPENDS entries MUST end
>>>>>> with the flavor so that the framework knows which to build/use. This is done
>>>>>> - by appending '@${PY_FLAVOR}' after the origin (or @${FLAVOR} if in a Python
>>>>>> - module with Python flavors, as the content will be the same). For example:
>>>>>> + by appending '@${PY_FLAVOR}' after the origin. For example:
>>>>>>
>>>>>> RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_FLAVOR}
>>>>>
>>>>> There are still some dependencies under Mk/ without @${PY_FLAVOR}.
>>>>
>>>> I cannot find any, can you be less vague? (or better, just fix them.)
>>>>
>>>
>>> Some lines that look suspicious:
>>
>> All of those only work with Python 2.7, they all depend on a file
>> though, so they are more or less flavor independant, and will work if
>> the default is not 2.7.
>
> But a port like devel/py-gobject is still flavored even if it has only
> one flavor. Are you saying that in that case depending on category/port
> without @flavor is fine?
Like py-* ports' consumers that don't import dependency from within python
and thus don't care about python version.
> I think I prefer to keep it simple and always require @flavor, like it
> says in the text above.
Blindly adding @flavor breaks with USE_PYTHON=concurrent dependencies e.g.,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227573
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227260
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fu2h-6lbm-wny>