From owner-cvs-src@FreeBSD.ORG Sun Jul 3 01:11:03 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FA0016A8E4; Sun, 3 Jul 2005 00:58:39 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE26F446B9; Sun, 3 Jul 2005 00:42:59 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 41C5E6DCC1; Sat, 2 Jul 2005 17:38:12 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id A27DA5C9C6 for ; Tue, 25 Jan 2005 07:39:53 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 8A14156BCF for ; Tue, 25 Jan 2005 15:39:53 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id D240016A537; Tue, 25 Jan 2005 15:39:49 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id BA21416A4D0; Tue, 25 Jan 2005 15:39:47 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8E4A16A4CE; Tue, 25 Jan 2005 15:39:46 +0000 (GMT) Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id E13F443D48; Tue, 25 Jan 2005 15:39:45 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j0PFdig1086670; Tue, 25 Jan 2005 16:39:44 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: "Jacques A. Vidrine" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 25 Jan 2005 09:37:29 CST." <20050125153729.GF5662@lum.celabo.org> Message-ID: <86669.1106667584@critter.freebsd.dk> Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: Andrey Chernov , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sys_generic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:11:04 -0000 X-Original-Date: Tue, 25 Jan 2005 16:39:44 +0100 X-List-Received-Date: Sun, 03 Jul 2005 01:11:04 -0000 In message <20050125153729.GF5662@lum.celabo.org>, "Jacques A. Vidrine" writes: >On Tue, Jan 25, 2005 at 12:42:26PM +0300, Andrey Chernov wrote: >> On Tue, Jan 25, 2005 at 09:15:32AM +0000, Poul-Henning Kamp wrote: >> > sys/kern sys_generic.c >> > Log: >> > Previously a read of zero bytes got handled in devfs:vop_read() but I >> > missed that when the vnode bypass was introduced. >> > >> > Deal with zero length transfers before we even get to fo_ops->fo_read(). >> >> Please back it out. Zero bytes read may affect atime, now not. > >I do not think that a zero byte read should not affect atime. Explain to me then why open+mmap doesn't affect atime isn't a bigger problem ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.