Date: Mon, 25 Feb 2019 07:12:15 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Mateusz Piotrowski <0mp@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344518 - head/share/man/man9 Message-ID: <9F0A25DA-E0D2-4F96-91AF-4648367E3E5F@gmail.com> In-Reply-To: <201902251503.x1PF3otL011409@repo.freebsd.org> References: <201902251503.x1PF3otL011409@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 25, 2019, at 07:03, Mateusz Piotrowski <0mp@freebsd.org> wrote: >=20 > Author: 0mp (ports committer) > Date: Mon Feb 25 15:03:50 2019 > New Revision: 344518 > URL: https://svnweb.freebsd.org/changeset/base/344518 >=20 > Log: > Add missing types to the sysctl(9) manual page >=20 > Update the diff to include other missing sysctl types found in sysctl.h. >=20 > Some of these sysctls are already documented in other pages (e.g counter(= 9) > and ZONE(9)), but they should at least be mentioned here for completeness= . >=20 > This patch now documents all of the following: > - SYSCTL_BOOL/SYSCTL_ADD_BOOL > - SYSCTL_COUNTER_U64/SYSCTL_ADD_COUNTER_U64 > - SYSCTL_COUNTER_U64_ARRAY/SYSCTL_ADD_COUNTER_U64_ARRAY > - SYSCTL_SBINTIME_MSEC/SYSCTL_ADD_SBINTIME_MSEC > - SYSCTL_SBINTIME_USEC/SYSCTL_ADD_SBINTIME_USEC > - SYSCTL_UMA_CUR/SYSCTL_ADD_UMA_CUR > - SYSCTL_UMA_MAX/SYSCTL_ADD_UMA_MAX >=20 > Submitted by: mhorne063_gmail.com > Reviewed by: bcr, hselasky > Approved by: bcr (doc), hselasky (src) > Approved by: krion (mentor, implicit), mat (mentor, implicit) > Differential Revision: https://reviews.freebsd.org/D19272 >=20 > Modified: > head/share/man/man9/sysctl.9 ... > @@ -52,10 +57,15 @@ > .Nm SYSCTL_ADD_UINT , > .Nm SYSCTL_ADD_ULONG , > .Nm SYSCTL_ADD_UQUAD , > +.Nm SYSCTL_ADD_UMA_CUR , > +.Nm SYSCTL_ADD_UMA_MAX , Same as my comment below. > .Nm SYSCTL_CHILDREN , > .Nm SYSCTL_STATIC_CHILDREN , > .Nm SYSCTL_NODE_CHILDREN , > .Nm SYSCTL_PARENT , > +.Nm SYSCTL_BOOL , > +.Nm SYSCTL_COUNTER_U64 , > +.Nm SYSCTL_COUNTER_U64_ARRAY , > .Nm SYSCTL_INT , > .Nm SYSCTL_INT_WITH_LABEL , > .Nm SYSCTL_LONG , > @@ -69,6 +79,8 @@ > .Nm SYSCTL_S16 , > .Nm SYSCTL_S32 , > .Nm SYSCTL_S64 , > +.Nm SYSCTL_SBINTIME_MSEC , > +.Nm SYSCTL_SBINTIME_USEC , > .Nm SYSCTL_STRING , > .Nm SYSCTL_STRUCT , > .Nm SYSCTL_U8 , > @@ -77,13 +89,47 @@ > .Nm SYSCTL_U64 , > .Nm SYSCTL_UINT , > .Nm SYSCTL_ULONG , > -.Nm SYSCTL_UQUAD > +.Nm SYSCTL_UQUAD , > +.Nm SYSCTL_UMA_CUR , > +.Nm SYSCTL_UMA_MAX Quick nit: UMA sorts before UQUAD. Also, these APIs deserve manpage links via MLINKS. Cheers! -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9F0A25DA-E0D2-4F96-91AF-4648367E3E5F>