Date: Fri, 10 Jun 2016 09:14:55 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301777 - head/lib/libc/stdio Message-ID: <03897eab-0725-7c7a-0edf-04eb44eff6f7@FreeBSD.org> In-Reply-To: <52d3a4b3-0b52-abd3-8633-909885f12781@freebsd.org> References: <201606100521.u5A5Lqa6035072@repo.freebsd.org> <3346cab5-d713-c1ad-5e50-ea8d50ee47b9@freebsd.org> <cd74f302-f089-3208-a6ca-89eb7460d41b@FreeBSD.org> <52d3a4b3-0b52-abd3-8633-909885f12781@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/10/16 07:19, Andrey Chernov wrote: > On 10.06.2016 15:03, Pedro Giffuni wrote: >> (Sorry I have been offline/sleep for a while) >> >> Hello; >> >> I cannot back this out because of this report: >> >> http://docs.freebsd.org/cgi/mid.cgi?20160608132224.GA15454 >> >> This change only re-states what has been working before the ABI breakage >> fix in r301461. > > Because now strcoll_l() is used as before and it is broken in wide char > converting process. It is broken for _all_, not just for vfscanf() > ranges. It should never fail with any args. > Real fix should be in strcoll_l(). > Yes, it is broken as before however the objective of r301461 was only to address the ABI breakage. If I revert r301777 then I have to backout r301461 too, and then we have again the ABI breakage. I understand you want to fix all but we are under code freeze and I have to go back to a known working (although still broken) state. >> The fix to regex is completely independent. > > It is dependent. vfscanf() and regcomp() use the same code for range > collation. If we remove range collation from everywhere, we save > vfscanf(), but strcoll_l() remains broken. > > We have had a broken regex for a very long time, and we new that before collation was introduced. I didn't take that decision but moving to libtre was a lot more work and we really had to have collation now. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?03897eab-0725-7c7a-0edf-04eb44eff6f7>