From owner-svn-src-all@FreeBSD.ORG Wed Jan 21 07:54:17 2015 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3E6A8C6F; Wed, 21 Jan 2015 07:54:17 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A1F6B6D2; Wed, 21 Jan 2015 07:54:16 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t0L7sBaO012198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 21 Jan 2015 09:54:11 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t0L7sBaO012198 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t0L7sAfU012197; Wed, 21 Jan 2015 09:54:10 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 21 Jan 2015 09:54:10 +0200 From: Konstantin Belousov To: Nathan Whitehorn Subject: Re: svn commit: r277421 - head/sys/powerpc/powerpc Message-ID: <20150121075410.GM42409@kib.kiev.ua> References: <201501201621.t0KGLx26096724@svn.freebsd.org> <20150120191438.GL42409@kib.kiev.ua> <54BF240C.2090107@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54BF240C.2090107@freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 07:54:17 -0000 On Tue, Jan 20, 2015 at 07:59:08PM -0800, Nathan Whitehorn wrote: > > On 01/20/15 11:14, Konstantin Belousov wrote: > > On Tue, Jan 20, 2015 at 04:21:59PM +0000, Nathan Whitehorn wrote: > >> Author: nwhitehorn > >> Date: Tue Jan 20 16:21:59 2015 > >> New Revision: 277421 > >> URL: https://svnweb.freebsd.org/changeset/base/277421 > >> > >> Log: > >> There does not seem to be any reason to acquire GIANT here. Follow amd64 > >> in removing it. > >> > >> MFC after: 1 month > >> > >> Modified: > >> head/sys/powerpc/powerpc/mem.c > >> > >> Modified: head/sys/powerpc/powerpc/mem.c > >> ============================================================================== > >> --- head/sys/powerpc/powerpc/mem.c Tue Jan 20 15:45:09 2015 (r277420) > >> +++ head/sys/powerpc/powerpc/mem.c Tue Jan 20 16:21:59 2015 (r277421) > >> @@ -100,8 +100,6 @@ memrw(struct cdev *dev, struct uio *uio, > >> cnt = 0; > >> error = 0; > >> > >> - GIANT_REQUIRED; > >> - > > This is not an acquisition, to be pedantic. Really, it is cdevsw which > > has D_NEEDGIANT flag which acquires Giant. After architectures get > > rid of GIANT_REQUIRED, flag can be removed. > > > Just so I understand, you are not objecting to this commit, right? Absolutely not, this is the right thing to do. > Just > pointing out that (a) my commit message was wrong and that (b) once all > architectures make this change (presumably more involved) we can get rid > of the D_NEEDGIANT in /sys/dev/mem/memdev.c? Exactly.