Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Sep 2019 16:33:15 -0400
From:      Charlie Li <ml+freebsd@vishwin.info>
To:        Baptiste Daroussin <bapt@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r352275 - in head/lib/libedit: . TEST edit readline
Message-ID:  <6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43@vishwin.info>
In-Reply-To: <201909130650.x8D6o2fb037276@repo.freebsd.org>
References:  <201909130650.x8D6o2fb037276@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--T3iMzCjUadTz6AS8VbqlUWsykLa71w3Q2
Content-Type: multipart/mixed; boundary="YDnxR0dO5qBLDGmHiI2S3ZODSkucUIqLj"

--YDnxR0dO5qBLDGmHiI2S3ZODSkucUIqLj
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

Baptiste Daroussin wrote:
> Author: bapt
> Date: Fri Sep 13 06:50:02 2019
> New Revision: 352275
> URL: https://svnweb.freebsd.org/changeset/base/352275
>=20
> Log:
>   Update libedit to a snapshot from 2019-09-10
>   Reviewed by:	Yuichiro Naito <naito.yuichiro_gmail.com>
>   MFC after:	3 weeks
>   Differential Revision:	https://reviews.freebsd.org/D21584
>=20
I posted in phab but repeating here, this breaks the build on (at least)
aarch64:

--- terminal.o ---
/usr/src/contrib/libedit/terminal.c:569:41: error: comparison of
integers of different signs: 'wint_t' (aka 'int') and 'wchar_t' (aka
'unsigned int') [-Werror,-Wsign-compare]
                                            el->el_cursor.v][where &
0370] !=3D
                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~=
~ ^
/usr/src/contrib/libedit/terminal.c:659:28: error: comparison of
integers of different signs: 'wint_t' (aka 'int') and 'wchar_t' (aka
'unsigned int') [-Werror,-Wsign-compare]
                                            [el->el_cursor.h] =3D=3D
MB_FILL_CHAR)
                                            ~~~~~~~~~~~~~~~~~ ^
~~~~~~~~~~~~
2 errors generated.
*** [terminal.o] Error code 1

--=20
Charlie Li
=E2=80=A6nope, still don't have an exit line.

(This email address is for mailing list use; replace local-part with
vishwin for off-list communication if possible)


--YDnxR0dO5qBLDGmHiI2S3ZODSkucUIqLj--

--T3iMzCjUadTz6AS8VbqlUWsykLa71w3Q2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE/3/Cqr5a+41PbEb+jnB43vIDq2wFAl17/RMACgkQjnB43vID
q2xLvg/+MeYyPTUDxqwK8BID1M5NCFx38at/jWMbIjbvBT0ywcoJxvZa/XQr3zof
ZBxtLUAmsd1M35SrYxpNjjjz9D2TUwbE6Ba/Jr3NuplGf3uV/1DHA2v2ZSw1j1w1
Lk+Hx94GMXs1SYhqhxyXQvv3Syq9rkkRIBAJSi+9LmCMHyz2LchPGI4zGw+7dON/
A9uz/lfA0K+nt3E02kifc7wOxQwfzAk5dJUJt3S9d9nrJzDiiZjtCbq92Nb7nqiG
UURv3XufECmeyy2GObdJDZz6A3SpznZVNISNsql2FecAaFabA7dhCipvzgVPN8rM
Fh4fHzCjSzVLm6A88QHnxrqjqnfV0kiZ00Jao0xVJDE250OaS/qSW1K5+WMHS2+C
6yko2bZU4wF8ETWTop3+EFr3u71ZMuvPFUGBSMYtW6sfyYxWMTC7kdF3J2UCh4fI
21yD/mGjuA6I9X9xMTayGkzq/0IYCHa646xcQYjQZd70WYJL696LGR1qCxjDTHGA
T8c7GtciCoMRmBcwxaEC5DQqQG/q866CWWkWuxKM+e37e2jJBIvFhf4c5TWpVKDe
4jHAzEzhsiO6lDnzzOAL2doHObqd/9Sjj/fYTACgjMhamJXQvFAlxrRoB6ymKhNo
3Yni5PdM1ocusVx9XcqQADeFnNmz+bnqMLma0+daGY4TWKqlpTI=
=WNTh
-----END PGP SIGNATURE-----

--T3iMzCjUadTz6AS8VbqlUWsykLa71w3Q2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43>