From owner-svn-ports-all@freebsd.org  Wed Aug 19 15:59:35 2015
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B81909BE721;
 Wed, 19 Aug 2015 15:59:35 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from vps.amdmi3.ru (vps.amdmi3.ru [109.234.38.216])
 by mx1.freebsd.org (Postfix) with ESMTP id 7F91716D;
 Wed, 19 Aug 2015 15:59:35 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from hive.panopticon (unknown [78.153.152.119])
 by vps.amdmi3.ru (Postfix) with ESMTPS id CD3E5B05F9;
 Wed, 19 Aug 2015 18:59:32 +0300 (MSK)
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
 by hive.panopticon (Postfix) with ESMTP id 3275D876;
 Wed, 19 Aug 2015 18:56:57 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
 id 717873F772; Wed, 19 Aug 2015 18:55:43 +0300 (MSK)
Date: Wed, 19 Aug 2015 18:55:43 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r394782 - head/games/dangen
Message-ID: <20150819155543.GB42382@hades.panopticon>
References: <201508191358.t7JDw7aV062421@repo.freebsd.org>
 <BC758709A8CCB114B14581F0@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <BC758709A8CCB114B14581F0@atuin.in.mat.cc>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Aug 2015 15:59:35 -0000

* Mathieu Arnold (mat@FreeBSD.org) wrote:
> +--On 19 août 2015 13:58:07 +0000 Dmitry Marakasov <amdmi3@FreeBSD.org>
> wrote:
> |  
> | -.include <bsd.port.options.mk>
> | -
> |  post-install:
> | -.if ${PORT_OPTIONS:MDOCS}
> |  	${MKDIR} ${STAGEDIR}${DOCSDIR}
> |  	${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}/
> | -.endif
> 
> This bit was not part of the commit message, which is bad :-)

I thought of it as too minor to mention.

> Having said that, you can now use the post-install-DOCS-on target in there,
> it will only run when the DOCS option is enabled.

Oh, thanks for reminding! I guess I'll adopt more of that in my
ports. Could you suggest a meaningful commit message for such
changes? "Use conditional targets"?

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru      http://amdmi3.ru