From owner-freebsd-current  Thu Oct 19 17:11:28 2000
Delivered-To: freebsd-current@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 821)
	id 02EF737B4CF; Thu, 19 Oct 2000 17:11:27 -0700 (PDT)
Date: Thu, 19 Oct 2000 17:11:26 -0700
From: "John W. De Boskey" <jwd@FreeBSD.org>
To: freebsd-current@FreeBSD.org
Subject: -current GENERIC failure (bktr_os.c:484)
Message-ID: <20001019171126.A10513@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Hi,

   I'm seeing the following failure with sources current
as of 19:39pm EDT (Oct 19). Occurs when building the GENERIC kernel.

   

cc -pipe -g  -D_KERNEL -Wall -Wredundant-decls -Wnested-externs
-Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual
-fformat-extensions -ansi -DKLD_MODULE -nostdinc -I-  -I. -I@ -I@/../include
-mpreferred-stack-boundary=2 -c
/usr/src/sys/modules/bktr/bktr/../../../dev/bktr/bktr_os.c
/usr/src/sys/modules/bktr/bktr/../../../dev/bktr/bktr_os.c: In function
`bktr_detach':
/usr/src/sys/modules/bktr/bktr/../../../dev/bktr/bktr_os.c:484: `unit'
undeclared (first use in this function)
/usr/src/sys/modules/bktr/bktr/../../../dev/bktr/bktr_os.c:484: (Each
undeclared identifier is reported only once
/usr/src/sys/modules/bktr/bktr/../../../dev/bktr/bktr_os.c:484: for each
function it appears in.)
*** Error code 1

Stop in /usr/src/sys/modules/bktr/bktr.
*** Error code 1

   From the source:

#if (__FreeBSD_version >=500000)
        if (unit == 0) {
            destroy_dev(bktr->vbidev_alias);
            destroy_dev(bktr->tunerdev_alias);
            destroy_dev(bktr->bktrdev_alias);
        }
#endif

   
   Looks like we need a:

        unsigned int    unit;

        unit = device_get_unit(dev);

   at the head of the function (wrapped in __FreeBSD_version >=500000 ??)

   Comments welcome.

Thanks,
John


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message