Date: Sat, 12 Sep 2015 12:27:59 +0100 From: RW <rwmaillists@googlemail.com> To: ports@freebsd.org Subject: Re: rc script problem - pidfile not being recognised Message-ID: <20150912122759.412ea139@gumby.homeunix.com> In-Reply-To: <55F367CF.2080507@sorbs.net> References: <20150911161850.402b3d5a@gumby.homeunix.com> <853047065.182.1441986957380.JavaMail.Kevin@Thoth> <20150911171930.59e67cc2@gumby.homeunix.com> <0NUI007RMV24EUD0@hades.sorbs.net> <55F367CF.2080507@sorbs.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 12 Sep 2015 01:46:23 +0200 Michelle Sullivan wrote: > Roger Marquis wrote: > > RW via freebsd-ports wrote: > >> It needs both. It won't use just the pid file because the pid > >> might have been reassigned to another process if the original > >> daemon died without deleting its pid file. > > > > Why would this rc script *require* a command_interpreter variable > > to use the pidfile variable? I'm curious because this violates > > KIS, the principle of least surprise and few rc scripts seem to > > have this variable defined. > > > > Using command_interpreter is good to be sure, for for the reason > > listed, but rc scripts should not fail if it is undefined. > > +1 to that. You'd rather an rc script fails at run-time and shuts down the wrong daemon than fail when the script is being developed?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150912122759.412ea139>