From owner-cvs-all@FreeBSD.ORG Sat Feb 3 23:19:01 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2E76616A402; Sat, 3 Feb 2007 23:19:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id E2DFB13C428; Sat, 3 Feb 2007 23:19:00 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l13NIPUT001256; Sat, 3 Feb 2007 16:18:25 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sat, 03 Feb 2007 16:18:57 -0700 (MST) Message-Id: <20070203.161857.1586001550.imp@bsdimp.com> To: gurney_j@resnet.uoregon.edu From: "M. Warner Losh" In-Reply-To: <20070203194700.GF779@funkthat.com> References: <200702030645.l136j3EQ039631@repoman.freebsd.org> <20070203194700.GF779@funkthat.com> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sat, 03 Feb 2007 16:18:25 -0700 (MST) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Feb 2007 23:19:01 -0000 In message: <20070203194700.GF779@funkthat.com> John-Mark Gurney writes: : Warner Losh wrote this message on Sat, Feb 03, 2007 at 06:45 +0000: : > imp 2007-02-03 06:45:02 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/conf files : > Log: : > Mark mmc *_if.m files as standard to allow for mmc/sd being compiled : > as a module. : > : > Submitted by: Andrea Bittau : : Those files don't need to be marked standard to allow module building.. : Either you can compile the *_if.c file as a seperate module and depend : upon them, or compile the *_if.c into the module directly... : : Many other modules do not require their *_if.m files to be marked : standard... : : It looks like some others could possibly be cleaned up and not made : standard, such as eisa... Sadly, these do need to be standard to actually load the drivers. The reason they are all marked standard is because it is hard to get the inter-module loading issues if they aren't. The problem is best illustrated by pccard. pccard provides interfaces to cbb to call, as well as calls cbb interfaces. Using a module depends makes it so you can't unload either of the modules... Warner