Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Oct 2000 13:50:15 -0700
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        Bosko Milekic <bmilekic@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/alpha/alpha machdep.c src/sys/i386/i386 machdep.c src/sys/kern uipc_mbuf.c src/sys/pc98/i386 machdep.c src/sys/sys kernel.h mbuf.h
Message-ID:  <20001002135015.A41068@dragon.nuxi.com>
In-Reply-To: <200009300630.XAA35447@freefall.freebsd.org>; from bmilekic@FreeBSD.org on Fri, Sep 29, 2000 at 11:30:40PM -0700
References:  <200009300630.XAA35447@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 29, 2000 at 11:30:40PM -0700, Bosko Milekic wrote:
> bmilekic    2000/09/29 23:30:40 PDT
> 
>   Modified files:
>     sys/alpha/alpha      machdep.c 
>     sys/i386/i386        machdep.c 
>     sys/kern             uipc_mbuf.c 
>     sys/pc98/i386        machdep.c 
>     sys/sys              kernel.h mbuf.h 
>   Log:
>    Big mbuf subsystem diff #1: incorporate mutexes and fix things up somewhat
>    to accomodate the changes.

This chagne was NOT TESTED in a ``make buildworld''.  Your changes to
sys/sys/mbuf.h is what broke the build in src/contrib/amd.  Also you
stayed silent when there were reports of world breakage and you knew you
had made a very recent commit.  Tracking this down took 3 hours and I
took quite a bit of flack over it.  I did not appreciate this.

``make buildworld'' should *ALWAYS* be done before a commit (especially
one of this size).  If other local changes make you not trust a ``make
buildworld'' then you should have a virgin src tree where you CVSup right
after a commit and do a ``make buildworld'' test there.

-- 
-- David  (obrien@FreeBSD.org)


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001002135015.A41068>