Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Jan 2021 00:56:26 +0800
From:      Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Steve Wills <swills@freebsd.org>
Cc:        ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r560241 - head/devel/readline
Message-ID:  <CAMHz58TtSMtr=8t5mG31raOgQ5XZQYXvTdatYbagDw8_ysxTWw@mail.gmail.com>
In-Reply-To: <8ffc93fb-5efb-d40b-edf0-591ca3cf2676@FreeBSD.org>
References:  <202101032029.103KTsw0028112@repo.freebsd.org> <5d52f437-618a-0da2-c8eb-a403a7e401fc@FreeBSD.org> <CAMHz58SirFY8zaCWUnJigoj0AnHh6WLvZeGC%2B1kwuSrV_3=UCw@mail.gmail.com> <8ffc93fb-5efb-d40b-edf0-591ca3cf2676@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 5, 2021 at 12:22 AM Steve Wills <swills@freebsd.org> wrote:

> Hi,
>
> On 1/4/21 10:36 AM, Po-Chuan Hsieh wrote:
> >
> >
> > I also considered PREFIX while preparing the patch. On second thought, I
> > think LOCALBASE is the right answer since inputrc is not part of the
> > readline package.
>
> I disagree, the inputrc file is a file that could very well be part of
> the readline package if it installed a sample, see attached.
>
> It's a readline file, not something installed some other package. It may
> be installed or edit by the admin user, but that applies to all config
> files.
>
> LOCALBASE is "files installed by other packages".
>
> So, PREFIX is correct and LOCALBASE is not.
>

OK, I get your point. I've changed it to patch file and PREFIX in r560398.
Thanks!


>
> Cheers,
> Steve
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58TtSMtr=8t5mG31raOgQ5XZQYXvTdatYbagDw8_ysxTWw>