From owner-svn-src-all@FreeBSD.ORG Thu Jun 11 00:29:10 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 77618106564A; Thu, 11 Jun 2009 00:29:10 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail09.syd.optusnet.com.au (mail09.syd.optusnet.com.au [211.29.132.190]) by mx1.freebsd.org (Postfix) with ESMTP id 0AF308FC1F; Thu, 11 Jun 2009 00:29:09 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c122-106-159-184.carlnfd1.nsw.optusnet.com.au (c122-106-159-184.carlnfd1.nsw.optusnet.com.au [122.106.159.184]) by mail09.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id n5B0T6Bm029557 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 11 Jun 2009 10:29:07 +1000 Date: Thu, 11 Jun 2009 10:29:06 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: "Bjoern A. Zeeb" In-Reply-To: <20090610112430.X22887@maildrop.int.zabbadoz.net> Message-ID: <20090611102156.E20959@delplex.bde.org> References: <200906090903.n5993D3E062579@svn.freebsd.org> <20090609090541.D22887@maildrop.int.zabbadoz.net> <20090610175011.E20224@delplex.bde.org> <20090610101009.N22887@maildrop.int.zabbadoz.net> <20090610102419.Q22887@maildrop.int.zabbadoz.net> <20090610184521.56b24c2f.ariff@FreeBSD.org> <20090610112430.X22887@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, brde@optusnet.com.au, Ariff Abdullah Subject: Re: kmod.mk - modules build framework [was: svn commit: r193818 - head/sys/modules/sound/sound] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2009 00:29:11 -0000 On Wed, 10 Jun 2009, Bjoern A. Zeeb wrote: > On Wed, 10 Jun 2009, Ariff Abdullah wrote: > >> On Wed, 10 Jun 2009 10:24:46 +0000 (UTC) >> "Bjoern A. Zeeb" wrote: >>> On Wed, 10 Jun 2009, Bjoern A. Zeeb wrote: >>> >>>> On Wed, 10 Jun 2009, Bruce Evans wrote: >>>> >>>>> On Tue, 9 Jun 2009, Bjoern A. Zeeb wrote: >>>>> >>>>>> On Tue, 9 Jun 2009, Bjoern A. Zeeb wrote: Too hard to untangle these quotes so I left them all. >>>>>>> Log: >>>>>>> Depend on @ machine (_ILINKS) as we do with other modules so >>>> that @ >>> is there for parallel (-jN) builds. Ideally >>>> beforedepends in kmod.mk >>> should do the right thing but it >>>> seems it does not. >> >>>>>> Anyone with lots of build framework know how may want to look at >>>> this. > >>>>> Failures only for parallel builds normally mean missing >>>> dependencies. > >>>>>>> -feeder_eq_gen.h: >>>>>>> +feeder_eq_gen.h: @ machine >>>>>>> ${AWK} -f @/tools/feeder_eq_mkfilter.awk -- >>>> ${FEEDER_EQ_PRESETS} > >>> ${.TARGET} >>>>> >>>>> Here there is still a missing dependency on the >>>>> @/tools/feeder_eq_mkfilter.awk (fixed in the next commit). This >>>> dependency > is not very important, but since the utility has "@" >>>> in its pathname, > running it certainly depends on "@". >>>> >>>> And adding it again messes with @ not being there for parallel >>>> builds:( >>>> >>>> Or in other words: >>>> >>>> ===> sound (depend) >>>> ===> sound/sound (depend) >>>> make: don't know how to make @/tools/sound/feeder_eq_mkfilter.awk. >>>> Stop *** Error code 2 >>>> 1 error >>>> *** Error code 2 >>>> 1 error >>>> *** Error code 2 >>> >>> I forgot to mention that the way we currently seem to handle this >>> is: >>> >>> http://people.freebsd.org/~bz/20090610-02-sound-Makefile.diff >>> >> >> More or less like: >> >> http://people.freebsd.org/~ariff/sound_Makefile.diff > > just seen it on current@. > >> Please test it. I only looked at the committed version. > Mine worked for me and that's consistent with what we do in > sys/modules/svr4/Makefile and sys/modules/linux/Makefile . These (and your patch) are more similar to what kmod.mk does for vnode_if.awk -- probably equivalent as my first attempt for vnode_if.awk in kmod.mk 1.67 -- but they are missing the subtleties in kmod.mk 1.95 and 1.176. Perhaps all versions for the sound files can be made more consise using for loops. Bruce