Date: Mon, 30 Jan 2006 12:15:58 +0000 (UTC) From: Ariff Abdullah <ariff@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern subr_hints.c Message-ID: <200601301215.k0UCFwZD084901@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ariff 2006-01-30 12:15:58 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_5)
sys/kern subr_hints.c
Log:
MFC:
The resource_xxx routines in subr_hints.c are called before and after the
kenv environment in kern_environment.c switches to dynamic kenv. The prior
call sets the static variable hintp to the static hints in subr_hints.c
(hintmode==0).
However, changes to the environment are not detected by the resource_xxx
lookups after the change to dynamic kernel environment, so the lookup
routines only report the old stuff of hintmode==0, even after the change to
the dynamic kenv. This causes kenv users to see a different environment than
the kernel routines.
This is a problem in the mixer.c code that looks up initial mixer volume
settings from the hints: If the hints are dynamic and not from the
device.hints file, mixer.c doesn't see them, but kenv does.
The patch from the PR (modified to comply to the style of the function)
solves this.
PR: 83686
Submitted by: Harry Coin <harrycoin@qconline.com>
Revision Changes Path
1.9.4.2 +2 -0 src/sys/kern/subr_hints.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601301215.k0UCFwZD084901>