Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Aug 2012 19:31:10 +0200
From:      Olli Hauer <ohauer@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r303150 - head/www/mod_auth_cas
Message-ID:  <50390BDE.20606@FreeBSD.org>
In-Reply-To: <20120825170211.GA34647@FreeBSD.org>
References:  <201208251648.q7PGmtS6066622@svn.freebsd.org> <20120825170211.GA34647@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-08-25 19:02, Alexey Dokuchaev wrote:
> On Sat, Aug 25, 2012 at 04:48:55PM +0000, Olli Hauer wrote:
>> New Revision: 303150
>> URL: http://svn.freebsd.org/changeset/ports/303150
>>
>> +post-install:
>> +	@${CAT} ${PKGMESSAGE}
>> +
> 
> cat(1)ing ${PKGMESSAGE} in post-install could benefit from being surrounded
> by ${ECHO_MSG}'s on both sides.  This makes installation from port and package
> behave similarly.
> 

I agree, thats why I always add a line with ========... at the top and at the bottom and have at last one whitespace before the text.
Instead two times ${ECHO_MSG} I would prefer an additional empty line at the top/bottom in pkg-message.

display installed from port:
[preparing module `auth_cas' in /usr/local/etc/apache22/httpd.conf]
======================================================================
 Set a few required parameters in your Apache configuration:

display installed from package (pkg):
Installing ap22-mod_auth_cas-1.0.9.1...[preparing module `auth_cas' in /usr/local/etc/apache22/httpd.conf]
 done
======================================================================
 Set a few required parameters in your Apache configuration:

--
Regards,
olli



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50390BDE.20606>