Date: Sat, 19 Mar 2005 14:27:24 +0100 (CET) From: Dag-Erling Smorgrav <des@des.no> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/79012: [PATCH] USE_PGSQL breaks dependency tracking Message-ID: <20050319132724.D94AF33C3E@xps.des.no> Resent-Message-ID: <200503191330.j2JDU3sK079409@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 79012
>Category: ports
>Synopsis: [PATCH] USE_PGSQL breaks dependency tracking
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 19 13:30:02 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Dag-Erling Smorgrav
>Release: FreeBSD 6.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD xps.des.no 6.0-CURRENT FreeBSD 6.0-CURRENT #20: Mon Mar 14 17:30:44 CET 2005 des@xps.des.no:/usr/obj/usr/src/sys/xps i386
ports-current
>Description:
If USE_PGSQL is set to a version which is not currently present in the
ports tree, the port is marked BROKEN. This makes it impossible to use
'make -VLIB_DEPENDS' in a partial tree to determine which dependencies
need updating, and breaks porteasy.
>How-To-Repeat:
# porteasy -r /home/pcvs -p /tmp/ports -bu databases/p5-DBD-Pg
Removing CLASSPATH from environment
Removing JAVA_HOME from environment
Removing LD_LIBRARY_PATH from environment
===> p5-DBD-Pg-1.40_1 is marked as broken: unknown PostgreSQL version: 74.
===> Cleaning for p5-DBI-1.48
===> Cleaning for perl-5.8.6_2
===> Cleaning for p5-DBD-Pg-1.40_1
# porteasy -r /home/pcvs -p /tmp/ports -l databases/p5-DBD-Pg
Removing CLASSPATH from environment
Removing JAVA_HOME from environment
Removing LD_LIBRARY_PATH from environment
* databases/p5-DBD-Pg (p5-DBD-Pg-1.40_1)
databases/p5-DBI (p5-DBI-1.48)
lang/perl5.8 (perl-5.8.6_2)
(note conspicuous absence of databases/postgresql74-client and its
dependencies)
>Fix:
Apply the attached patch.
--- use_pgsql.diff begins here ---
Index: Mk/bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.511
diff -u -r1.511 bsd.port.mk
--- Mk/bsd.port.mk 17 Mar 2005 23:22:07 -0000 1.511
+++ Mk/bsd.port.mk 19 Mar 2005 13:24:12 -0000
@@ -1732,7 +1732,6 @@
.endif
# And now we are checking if we can use it
-.if exists(${PORTSDIR}/databases/postgresql${PGSQL_VER}-client)
.if defined(BROKEN_WITH_PGSQL)
. for VER in ${BROKEN_WITH_PGSQL}
. if (${PGSQL_VER} == "${VER}")
@@ -1741,9 +1740,6 @@
. endfor
.endif # BROKEN_WITH_PGSQL
LIB_DEPENDS+= pq:${PORTSDIR}/databases/postgresql${PGSQL_VER}-client
-.else
-BROKEN= "unknown PostgreSQL version: ${PGSQL_VER}"
-.endif # Check for correct version
CPPFLAGS+= -I${LOCALBASE}/include
LDFLAGS+= -L${LOCALBASE}/lib
CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
--- use_pgsql.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050319132724.D94AF33C3E>