Date: Thu, 10 Sep 2015 16:59:23 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Wen Heping <wen@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396554 - in head/devel/liblouis: . files Message-ID: <si6m-s4l0-wny@FreeBSD.org> In-Reply-To: <201509100846.t8A8km40086266@repo.freebsd.org> (Wen Heping's message of "Thu, 10 Sep 2015 08:46:48 %2B0000 (UTC)") References: <201509100846.t8A8km40086266@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Not new in this version but you may need to add
BUILD_DEPENDS=3D help2man:${PORTSDIR}/misc/help2man
and populate pkg-plist due to
$ make check-plist
=3D=3D=3D=3D> Checking for pkg-plist issues (check-plist)
=3D=3D=3D> Parsing plist
=3D=3D=3D> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: man/man1/lou_allround.1.gz
Error: Orphaned: man/man1/lou_checkhyphens.1.gz
Error: Orphaned: man/man1/lou_checktable.1.gz
Error: Orphaned: man/man1/lou_debug.1.gz
Error: Orphaned: man/man1/lou_trace.1.gz
Error: Orphaned: man/man1/lou_translate.1.gz
=3D=3D=3D> Checking for items in pkg-plist which are not in STAGEDIR
=3D=3D=3D> Error: Plist issues found.
*** Error code 1
And LICENSE seems bogus as ${WRKSRC}/liblouis/*.c have:
This file is free software; you can redistribute it and/or modify it
under the terms of the Lesser or Library GNU General Public License=20
as published by the
Free Software Foundation; either version 3, or (at your option) any
later version.
Wen Heping <wen@FreeBSD.org> writes:
> -USES=3D gmake libtool
> +USES=3D gmake libtool autoreconf
[...]
> +pre-configure:
> + cd ${WRKSRC} && ./autogen.sh
>=20=20
USES=3Dautoreconf already runs autotools during configure stage. If you
only need its build dependencies do USES=3Dautoreconf:build.
However, the only difference between autogen.sh and USES=3Dautoreconf is
the clean up of working directory. The step is not necessary for a
freshly extracted tarball.
Also, sort USES to pet portlint.
> OPTIONS_DEFINE=3D DOCS
[...]
> - @${MKDIR} ${STAGEDIR}${DOCSDIR}
> -.for i in liblouis.html liblouis.txt
> - ${INSTALL_MAN} ${WRKSRC}/doc/${i} ${STAGEDIR}${DOCSDIR}
> -.endfor
[...]
> -%%PORTDOCS%%%%DOCSDIR%%/liblouis.html
> -%%PORTDOCS%%%%DOCSDIR%%/liblouis.txt
Why OPTIONS_DEFINE=3DDOCS was left out of the removal?
> + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/liblouis.so
Why not INSTALL_TARGET=3Dinstall-strip? It's always available in the
projects using automake i.e., a subset of ports with GNU_CONFIGURE.
> -libdata/pkgconfig/liblouis.pc
> +lib/pkgconfig/liblouis.pc
For a reason likely lost[1] in time devel/pkg-config and devel/pkgconf
use libdata/pkgconfig by default. As such using vendor defaults isn't
going to work with FreeBSD ports. Please, convert to
USES=3D ... pathfix
PATHFIX_MAKEFILEIN=3D Makefile.am
portlint -C should have warned you about this!
> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> +++ head/devel/liblouis/files/patch-autogen.sh Thu Sep 10 08:46:47 2015 (=
r396554)
> @@ -0,0 +1,13 @@
> +--- autogen.sh.orig 2015-09-10 16:17:51.726491000 +0800
> ++++ autogen.sh 2015-09-10 16:18:08.800813000 +0800
Please, keep new patches in |make makepatch| format. It puts the date of
the last *vendor* modification correctly.
=2D-
[1] Probably to mimic hier(7) but base distinction for lib and libdata
have also eroded:
/usr/lib/debug (from WITH_DEBUG_FILES)
/usr/libdata/ldscripts
/usr/lib/dtrace
/usr/libdata/gcc
/usr/lib/clang (on 11.0C)
/usr/include/gcc
/usr/include/clang (before 11.0C)
Index: devel/liblouis/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- devel/liblouis/Makefile (revision 396571)
+++ devel/liblouis/Makefile (working copy)
@@ -9,19 +9,15 @@ CATEGORIES=3D devel
MAINTAINER=3D wen@FreeBSD.org
COMMENT=3D Open-source Braille Translator And Back-translator
=20
=2DLICENSE=3D GPLv3
+LICENSE=3D LGPL3 # or any later version
=20
=2DOPTIONS_DEFINE=3D DOCS
+BUILD_DEPENDS=3D help2man:${PORTSDIR}/misc/help2man
=20
=2DUSES=3D gmake libtool autoreconf
+USES=3D autoreconf gmake libtool pathfix
USE_GITHUB=3D yes
GNU_CONFIGURE=3D yes
USE_LDCONFIG=3D yes
+PATHFIX_MAKEFILEIN=3D Makefile.am
+INSTALL_TARGET=3D install-strip
=20
=2Dpre-configure:
=2D cd ${WRKSRC} && ./autogen.sh
=2D
=2Dpost-install:
=2D ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/liblouis.so
=2D
.include <bsd.port.mk>
Index: devel/liblouis/files/patch-autogen.sh
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- devel/liblouis/files/patch-autogen.sh (revision 396571)
+++ devel/liblouis/files/patch-autogen.sh (working copy)
@@ -1,13 +0,0 @@
=2D--- autogen.sh.orig 2015-09-10 16:17:51.726491000 +0800
=2D+++ autogen.sh 2015-09-10 16:18:08.800813000 +0800
=2D@@ -28,8 +28,8 @@
=2D=20
=2D # Refresh GNU autotools toolchain.
=2D echo Cleaning autotools files...
=2D-find -type d -name autom4te.cache -print0 | xargs -0 rm -rf \;
=2D-find -type f \( -name missing -o -name install-sh -o -name mkinstalldir=
s \
=2D+find . -type d -name autom4te.cache -print0 | xargs -0 rm -rf \;
=2D+find . -type f \( -name missing -o -name install-sh -o -name mkinstalld=
irs \
=2D -o -name depcomp -o -name ltmain.sh -o -name configure \
=2D -o -name config.sub -o -name config.guess -o -name config.h.in \
=2D -o -name mdate-sh -o -name texinfo.tex \
Index: devel/liblouis/pkg-plist
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- devel/liblouis/pkg-plist (revision 396571)
+++ devel/liblouis/pkg-plist (working copy)
@@ -11,7 +11,13 @@ lib/liblouis.a
lib/liblouis.so
lib/liblouis.so.9
lib/liblouis.so.9.0.0
=2Dlib/pkgconfig/liblouis.pc
+libdata/pkgconfig/liblouis.pc
+man/man1/lou_allround.1.gz
+man/man1/lou_checkhyphens.1.gz
+man/man1/lou_checktable.1.gz
+man/man1/lou_debug.1.gz
+man/man1/lou_trace.1.gz
+man/man1/lou_translate.1.gz
%%DATADIR%%/tables/Cz-Cz-g1.utb
%%DATADIR%%/tables/Es-Es-G0.utb
%%DATADIR%%/tables/Es-Es-g1.utb
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJV8ZrLXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bwbcH/11vD7r9bPfJKqzii1C6XRPh
LZ2V1ZQKe/Lw3ZM3r7MXTPVtadB9iANOy3873HSFSPvFDyaxM/tPhip6qiowT8el
5Ce80Nn9+mYob4QqwgI7rU/i0T1UA+U7OZci1FR3JtSarG/ORjA/kquHKMt4YGxn
wCcJAhoWDXQsYDn4lxrdEYoytPaJ/4DbxZSy4UCipBeZL14Xj18noAzWzckvM8AB
HWTyM3faRERKyOAczAxzI4PotkDD3tP2IHGYc/nOIzmzK9wLGp9YEua1sIt19VWK
d2bMWrWnelBRPQIvFK0klqVmYjb5Ad/2XQboDy2Jm2uOQx95D7BtVjfv/30cXTw=
=0dLv
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?si6m-s4l0-wny>