Date: Wed, 19 Aug 2009 19:55:50 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: Attilio Rao <attilio@FreeBSD.org>, Sam Leffler <sam@errno.com>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r196358 - in head: share/man/man9 sys/kern sys/sys Message-ID: <20090819194425.S35105@delplex.bde.org> In-Reply-To: <20090818183858.GB1794@garage.freebsd.pl> References: <200908181355.n7IDtmqT019165@svn.freebsd.org> <4A8AC814.2070804@errno.com> <3bbf2fe10908181106u159934b9ofc4c2a5e4793b692@mail.gmail.com> <20090818183858.GB1794@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 18 Aug 2009, Pawel Jakub Dawidek wrote: > On Tue, Aug 18, 2009 at 08:06:17PM +0200, Attilio Rao wrote: >> 2009/8/18 Sam Leffler <sam@errno.com>: >>> Pawel Jakub Dawidek wrote: >>>> Log: >>>> Remove unused taskqueue_find() function. >>>> Reviewed by: dfr >>>> Approved by: re (kib) >>> >>> I don't understand why this should be removed (let alone during a code >>> freeze). I can think of several uses for this function including a ddb cmd >>> that takes a taskq name and dumps it's contents. The overhead of >>> maintaining the global list appears minimal. >> >> FWIW, I agree with Sam. > > The only use I could think of was exactly what Sam suggested - a DDB > command and that was the only possible use I found. And ddb cannot call it, since it uses locks unconditionally. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090819194425.S35105>