Date: Tue, 22 Oct 2013 15:55:20 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r331243 - head/sysutils/tmux Message-ID: <20131022155520.GA79375@FreeBSD.org> In-Reply-To: <526653CB.3080106@FreeBSD.org> References: <201310220906.r9M96xBM055204@svn.freebsd.org> <526653CB.3080106@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 22, 2013 at 05:30:35AM -0500, Bryan Drewery wrote:
> On 10/22/2013 4:06 AM, Mathieu Arnold wrote:
> > .if ${PORT_OPTIONS:MEXAMPLES}
> > - @${MKDIR} ${EXAMPLESDIR}
> > - @${INSTALL_DATA} ${WRKSRC}/examples/* ${EXAMPLESDIR}
> > + @${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
> > + @${INSTALL_DATA} ${WRKSRC}/examples/* ${STAGEDIR}${EXAMPLESDIR}
> > .endif
>
> I think the general trend is to not hide any install commands since it
> is touching the user's system, and is good for debugging build logs.
(Not just to Mathieu, writing this given another occasion.)
Yes, please, make installation commands vocal (muting mkdir's is optional,
some people like it, it's okay).
I would also like to mention that, unless DOCS/EXAMPLES require extra
dependencies (e.g. Doxygen/DocBook) or just huge enough to create insane
I/O load, for staged ports, you can remove those .if ${PORT_OPTIONS...}
checks. In many cases, it would collaterally allow to remove .include
<bsd.port.options.mk> (when there are no other PORT_OPTIONS checks).
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131022155520.GA79375>