From owner-cvs-all@FreeBSD.ORG Sun Mar 2 20:28:27 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C77F1106566B for ; Sun, 2 Mar 2008 20:28:27 +0000 (UTC) (envelope-from yar.tikhiy@gmail.com) Received: from rv-out-0910.google.com (rv-out-0910.google.com [209.85.198.186]) by mx1.freebsd.org (Postfix) with ESMTP id 83A4D8FC17 for ; Sun, 2 Mar 2008 20:28:27 +0000 (UTC) (envelope-from yar.tikhiy@gmail.com) Received: by rv-out-0910.google.com with SMTP id g13so4029189rvb.43 for ; Sun, 02 Mar 2008 12:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=cjEI6ViFpOWQHPzm3tloykQeNGLZlHrvscwuEGZ6eI4=; b=GBuMwUB7ErzAGgDjZ7kySit/weGZnAo9juR1Lt92z39rfuKbZ3t1QKiPzCqsGc8HgeDWVYxZVRqT+vuJ0BDgpJXoOPPuxBUKa82P509bcwYI0dc1ttZGSDeg1JHn33B/wNKjKF/Bpynlptz9p5SFzwiPdslLnrUUMqB/izLG7Ms= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=c1NPk8xrrxpJ1kJ9hPz6u2o60wqemi7nWknnnXw6OSWMZkmvWgdHRdUUTZ2xMkZPexP+UhSGFT52AQN6oVbmlzHKpJgpwCnokJv1U2RqLoSD/oXxEkZdYkXybpaAkyl3D56UZodfpvB1A6yLU5wCfJG3bz3ExGOcpia9PKY03Ws= Received: by 10.141.163.12 with SMTP id q12mr7470297rvo.265.1204488266639; Sun, 02 Mar 2008 12:04:26 -0800 (PST) Received: by 10.141.52.1 with HTTP; Sun, 2 Mar 2008 12:04:26 -0800 (PST) Message-ID: Date: Sun, 2 Mar 2008 23:04:26 +0300 From: "Yar Tikhiy" Sender: yar.tikhiy@gmail.com To: "Robert Watson" In-Reply-To: <200803021856.m22IuEAx019455@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200803021856.m22IuEAx019455@repoman.freebsd.org> X-Google-Sender-Auth: 345a4dd6f387e5a6 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/smbfs smbfs.h smbfs_node.c smbfs_vfsops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Mar 2008 20:28:27 -0000 On Sun, Mar 2, 2008 at 9:56 PM, Robert Watson wrote: > rwatson 2008-03-02 18:56:14 UTC > > FreeBSD src repository > > Modified files: > sys/fs/smbfs smbfs.h smbfs_node.c smbfs_vfsops.c > Log: > Replace lockmgr lock protecting smbfs node hash table with sx lock. This commit message is a textbook example of how not to write commit messages: It accurately re-tells what was obvious from the diff anyway but provides no pointers to the background for the change. Sorry for my bitching, but I just couldn't resist... :-) -- Yar