Date: Sun, 14 Nov 1999 23:22:16 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Marcel Moolenaar <marcel@scc.nl> Cc: Martin Cracauer <cracauer@cons.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include signal.h Message-ID: <Pine.BSF.4.10.9911142303390.21828-100000@alphplex.bde.org> In-Reply-To: <382E8A1B.B7D9B7F0@scc.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 14 Nov 1999, Marcel Moolenaar wrote:
> Martin Cracauer wrote:
> > > Reserve space for FPU state in struct sigcontext. Fix some style bugs
> > > and comments while there.
> >
> > I still don't like this approach of unstructred allocated space, an
> > array of unnamed bytes.
>
> It's what it says it is: it's a space reservation. If someone actually
> implements saving the FPU state, then he/she is free (IMO) to change the
> reservation into whatever he/she things he/she needs or thinks is
> meaningful.
Martin implemented saving it before you complicated things by changing
the signal handling :-). I didn't like it because it moved the definitions
of i386 FP structs to the wrong place (<machine/signal.h>). It's not
clear that there is a right place.
> The reason for the space reservation is to work towards an unified
> context. mcontext_t also has the space reservation...
We seem to have missed allocating some necessary space. glibc-2.1.1 has:
int sc_fpkind; /* FP_NO, FP_387, etc. */
int sc_fpused; /* If zero, ignore rest of float state. */
int at least some declarations of struct sigcontext.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9911142303390.21828-100000>