Date: Fri, 10 Oct 2014 16:50:43 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Ian Lepore <ian@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r272808 - head/include/rpcsvc Message-ID: <20141010145043.GI19486@ivaldir.etoilebsd.net> In-Reply-To: <1412949811.12052.270.camel@revolution.hippie.lan> References: <201410090658.s996wYOr096351@svn.freebsd.org> <1412949811.12052.270.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
--dMdWWqg3F2Dv/qfw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 10, 2014 at 08:03:31AM -0600, Ian Lepore wrote: > On Thu, 2014-10-09 at 06:58 +0000, Baptiste Daroussin wrote: > > Author: bapt > > Date: Thu Oct 9 06:58:33 2014 > > New Revision: 272808 > > URL: https://svnweb.freebsd.org/changeset/base/272808 > >=20 > > Log: > > Fix build with rpcgen using a recent (tested with gcc 4.9.1) GNU cpp > >=20 > > Modified: > > head/include/rpcsvc/nis.x > >=20 > > Modified: head/include/rpcsvc/nis.x > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/include/rpcsvc/nis.x Thu Oct 9 06:24:06 2014 (r272807) > > +++ head/include/rpcsvc/nis.x Thu Oct 9 06:58:33 2014 (r272808) > > @@ -400,10 +400,7 @@ program NIS_PROG { > > %#define OARIGHTS(d, n) (((d)->do_armask.do_armask_val+n)->oa_rights) > > %#define WORLD_DEFAULT (NIS_READ_ACC) > > %#define GROUP_DEFAULT (NIS_READ_ACC << 8) > > -%#define OWNER_DEFAULT ((NIS_READ_ACC +\ > > - NIS_MODIFY_ACC +\ > > - NIS_CREATE_ACC +\ > > - NIS_DESTROY_ACC) << 16) > > +%#define OWNER_DEFAULT ((NIS_READ_ACC + NIS_MODIFY_ACC + NIS_CREATE_AC= C + NIS_DESTROY_ACC) << 16) > > %#define DEFAULT_RIGHTS (WORLD_DEFAULT | GROUP_DEFAULT | OWNER_DEFAULT) > > % > > %/* Result manipulation defines ... */ > > @@ -432,10 +429,8 @@ program NIS_PROG { > > % * these definitions they take an nis_object *, and an int and return > > % * a u_char * for Value, and an int for length. > > % */ > > -%#define ENTRY_VAL(obj, col) \ > > - (obj)->EN_data.en_cols.en_cols_val[col].ec_value.ec_value_val > > -%#define ENTRY_LEN(obj, col) \ > > - (obj)->EN_data.en_cols.en_cols_val[col].ec_value.ec_value_len > > +%#define ENTRY_VAL(obj, col) (obj)->EN_data.en_cols.en_cols_val[col].e= c_value.ec_value_val > > +%#define ENTRY_LEN(obj, col) (obj)->EN_data.en_cols.en_cols_val[col].e= c_value.ec_value_len > > % > > %#ifdef __cplusplus > > %} > >=20 >=20 > How does unwrapping these lines so that they're longer than the style(9) > limits fix the build? >=20 > (I'm not a fan of 80-column limits, it's a rule that needs to die die > die. I'm just curious what the actual fix is here.) >=20 to be honnest here I don't know how rpcgen passes lines to cpp but recent G= NU cpp are failing because of that, looking at dragonfly I have seen they fixed the same way. regards, Bapt --dMdWWqg3F2Dv/qfw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlQ38kMACgkQ8kTtMUmk6ExXEACgkKzLE/G3quUVncTDKezXdbO+ nI4An1mh7DC8AsNMNHCh6wo10VyNdfk8 =LMei -----END PGP SIGNATURE----- --dMdWWqg3F2Dv/qfw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141010145043.GI19486>