From owner-cvs-all Sun Jun 30 1:24:45 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 280C037B405; Sun, 30 Jun 2002 01:24:37 -0700 (PDT) Received: from iguana.icir.org (iguana.icir.org [192.150.187.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id D05DA43E31; Sun, 30 Jun 2002 01:24:36 -0700 (PDT) (envelope-from rizzo@iguana.icir.org) Received: (from rizzo@localhost) by iguana.icir.org (8.11.6/8.11.3) id g5U8OXE79658; Sun, 30 Jun 2002 01:24:33 -0700 (PDT) (envelope-from rizzo) Date: Sun, 30 Jun 2002 01:24:33 -0700 From: Luigi Rizzo To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa clock.c src/sys/i386/include param.h src/sys/conf options.i386 Message-ID: <20020630012433.A79625@iguana.icir.org> References: <200206300756.g5U7unht089253@freefall.freebsd.org> <42548.1025424360@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <42548.1025424360@critter.freebsd.dk>; from phk@critter.freebsd.dk on Sun, Jun 30, 2002 at 10:06:00AM +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jun 30, 2002 at 10:06:00AM +0200, Poul-Henning Kamp wrote: > > Luigi, > > What is going on here ? I see no code even remotely like this in > -current. There is the KTR stuff in sys/kern/kern_ktr which does something similar. Much more heavyweight in my opinion, but that's just my personal opinion. Plus, have you read the last part of the commit message havent you ? > > I am committing this to RELENG_4 only because on -current parts of > > the kernel might run concurrently, so the use of a single unprotected > > static variable as the index of the next entry in the buffer might > > lead to inconsistent results. Plus, there might be similar stuff > > in -current already. > > > > If someone feels like porting this code to -current, it might be > > a good idea to keep separate per-cpu buffers to avoid the cost > > of protecting against concurrent accesses. > Surely you are not doing your development on -stable and forgetting > about -current ? God forbid, I would never commit such a mortal sin! cheers luigi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message