Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Dec 2017 14:04:06 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Yuri Victorovich <yuri@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r456877 - in head: . science/PETSc science/PETSc/files
Message-ID:  <20171224140406.GB1693@FreeBSD.org>
In-Reply-To: <201712210026.vBL0QxSl021548@repo.freebsd.org>
References:  <201712210026.vBL0QxSl021548@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 21, 2017 at 12:26:59AM +0000, Yuri Victorovich wrote:
> New Revision: 456877
> URL: https://svnweb.freebsd.org/changeset/ports/456877
> 
> Log:
>   [R]e-added port: science/PETSc: Suite of data structures and routines
>   from Argonne National Laboratory (existed 2004/11/21-2014/09/01,
>   deleted in r366959)
> 
> Added:
>   head/science/PETSc/
>      - copied from r366958, head/math/petsc/

:-(

> Modified: head/science/PETSc/Makefile
> ...
> @@ -1,303 +1,39 @@
>  # Created by: Thierry Thomas <thierry@pompo.net>
>  # $FreeBSD$
>  
> -PORTNAME=	petsc
> -DISTVERSION=	2.3.3-p0
> -PORTREVISION=	12
> -PORTEPOCH=	1
> -CATEGORIES=	math parallel
> -MASTER_SITES=	ftp://ftp.mcs.anl.gov/pub/petsc/release-snapshots/
> +PORTNAME=	PETSc
> +DISTVERSION=	3.8.3
> +CATEGORIES=	science devel
> +MASTER_SITES=	http://ftp.mcs.anl.gov/pub/petsc/release-snapshots/
> +DISTNAME=	${PORTNAME:tl}-${DISTVERSION}

It was properly named, and required no DISTFILE:tl dances.  Why would you
rename it?

> Modified: head/science/PETSc/pkg-descr
> ...
>  
> -WWW: http://www.mcs.anl.gov/petsc/
> +WWW: http://www.mcs.anl.gov/petsc

This change was uncalled for and is against the PHB recommendations (if
you open that URL in browser you'd notice that it's a directory, not a
file).

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171224140406.GB1693>