From owner-svn-ports-all@freebsd.org  Sun Dec 24 14:04:07 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30CA7E906D9;
 Sun, 24 Dec 2017 14:04:07 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0E4CB7AF4E;
 Sun, 24 Dec 2017 14:04:07 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 567922E42; Sun, 24 Dec 2017 14:04:06 +0000 (UTC)
Date: Sun, 24 Dec 2017 14:04:06 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Yuri Victorovich <yuri@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r456877 - in head: . science/PETSc science/PETSc/files
Message-ID: <20171224140406.GB1693@FreeBSD.org>
References: <201712210026.vBL0QxSl021548@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201712210026.vBL0QxSl021548@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Dec 2017 14:04:07 -0000

On Thu, Dec 21, 2017 at 12:26:59AM +0000, Yuri Victorovich wrote:
> New Revision: 456877
> URL: https://svnweb.freebsd.org/changeset/ports/456877
> 
> Log:
>   [R]e-added port: science/PETSc: Suite of data structures and routines
>   from Argonne National Laboratory (existed 2004/11/21-2014/09/01,
>   deleted in r366959)
> 
> Added:
>   head/science/PETSc/
>      - copied from r366958, head/math/petsc/

:-(

> Modified: head/science/PETSc/Makefile
> ...
> @@ -1,303 +1,39 @@
>  # Created by: Thierry Thomas <thierry@pompo.net>
>  # $FreeBSD$
>  
> -PORTNAME=	petsc
> -DISTVERSION=	2.3.3-p0
> -PORTREVISION=	12
> -PORTEPOCH=	1
> -CATEGORIES=	math parallel
> -MASTER_SITES=	ftp://ftp.mcs.anl.gov/pub/petsc/release-snapshots/
> +PORTNAME=	PETSc
> +DISTVERSION=	3.8.3
> +CATEGORIES=	science devel
> +MASTER_SITES=	http://ftp.mcs.anl.gov/pub/petsc/release-snapshots/
> +DISTNAME=	${PORTNAME:tl}-${DISTVERSION}

It was properly named, and required no DISTFILE:tl dances.  Why would you
rename it?

> Modified: head/science/PETSc/pkg-descr
> ...
>  
> -WWW: http://www.mcs.anl.gov/petsc/
> +WWW: http://www.mcs.anl.gov/petsc

This change was uncalled for and is against the PHB recommendations (if
you open that URL in browser you'd notice that it's a directory, not a
file).

./danfe