From owner-svn-src-all@freebsd.org Thu Feb 22 03:03:49 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A70A4F1FDC3; Thu, 22 Feb 2018 03:03:49 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3DCBE84FEA; Thu, 22 Feb 2018 03:03:49 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-it0-x230.google.com with SMTP id o13so4592906ito.2; Wed, 21 Feb 2018 19:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TXNGTqA4AMIeBH8S6sRW7XS9QpkKNIgxk+L9x/04q24=; b=sYga6ICiIXoK3X3HKfLoCHvtmmoaVuUr1d8odDCX0xmBADWr/GCICYVZDXrdSAA3S8 zG7T1/6sfrJ0isML+6Ax3gDST+VvWjwbwcsnKvV6kegUIraZ25Urf7BUE36OtPTEIKxq 57XJ+MlDS2Pf8MiZ7lCssxyK8YPnD0SnZRhE4Pz2UROZCetCYJPlJn4Bijif7fC+uhCl VEeJ+b3FrFuGrGrVb+HlfaVBpszXOjd/8tB4n2vLZK4ev0bAdcNN7YGaWv10p0GngCRZ 22CMiW5Q2lYo061p5OJ+3kE8FWlnZJSHDeQK3P2hai8MD5+KF/BUKTY+vn28f+z9fMyT eSZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TXNGTqA4AMIeBH8S6sRW7XS9QpkKNIgxk+L9x/04q24=; b=F0hAuLgyRlTc3pVD9SwdsRulPQXj9rDXPJ+G1prt4Oy9+1ACQa0qPE9PaGt7DfmSPO 4NCqOCR2eunC4EnpoqcB3Q5dMilaHr+eYyGu3B0s25HN6Cf8EioeB9myMxmdsOPMPB3Y 2/6Q+Vk+7mc1AEM2QCskAEmwKxtAlcB2ckv3I6/WNjB5QtoMIC5CuSZSOOyYWmhI93lD sBrEWmBlUKJMLrwPqoNms4jgjQCk813/D+yUVslo2m6TAMV5/0m3jByv0tMR34Ym3Q/R P/HI+gRpa4+bC8u1/ESAgz2i3yNaIOmQ0QD6KhDHSnEeQygzP+a5qhnsyiAXKq9U2DUK QaLQ== X-Gm-Message-State: APf1xPCJUC4beem2u1yJwTatGIWQFG7lmzmlpqYMfDh//bBgH/+KeL68 IMt504evWD4d0DYrLwW3m+ciZlZb X-Google-Smtp-Source: AG47ELtlJu7xqbUzr1JISXuPu2tdbBlCxQLY23cwhtIaGKfx5C9AjgC0UN7xkFjl8aUZlJIQepIDIA== X-Received: by 10.36.151.197 with SMTP id k188mr6444362ite.45.1519268628256; Wed, 21 Feb 2018 19:03:48 -0800 (PST) Received: from spectre.mavhome.dp.ua ([2600:1700:3580:3560:205:1bff:fee0:411b]) by smtp.gmail.com with ESMTPSA id j2sm10446356iob.43.2018.02.21.19.03.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Feb 2018 19:03:47 -0800 (PST) Sender: Alexander Motin Subject: Re: svn commit: r329770 - vendor-sys/illumos/dist/uts/common/fs/zfs/lua To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org References: <201802220104.w1M14uHQ088614@pdx.rh.CN85.dnsmgr.net> From: Alexander Motin Message-ID: <56dda9e2-e9ea-83b9-1e54-6569d478615a@FreeBSD.org> Date: Wed, 21 Feb 2018 22:03:47 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <201802220104.w1M14uHQ088614@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 03:03:50 -0000 On 21.02.2018 20:04, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> Author: mav >> Date: Thu Feb 22 00:46:24 2018 >> New Revision: 329770 >> URL: https://svnweb.freebsd.org/changeset/base/329770 >> >> Log: >> 9035 zfs: this statement may fall through >> >> illumos/illumos-gate@46ac8fdfc5a1f9d8240c79a6ae5b2889cbe83553 >> >> Reviewed by: Yuri Pankov >> Reviewed by: Andy Fiddaman >> Reviewed by: Matthew Ahrens >> Approved by: Dan McDonald >> Author: Toomas Soome >> >> Modified: >> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c >> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c >> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lstrlib.c >> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/ltable.c >> >> Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c >> ============================================================================== >> --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c Thu Feb 22 00:42:12 2018 (r329769) >> +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c Thu Feb 22 00:46:24 2018 (r329770) >> @@ -677,7 +677,7 @@ static void freeobj (lua_State *L, GCObject *o) { >> case LUA_TUSERDATA: luaM_freemem(L, o, sizeudata(gco2u(o))); break; >> case LUA_TSHRSTR: >> G(L)->strt.nuse--; >> - /* go through */ >> + /* FALLTHROUGH */ >> case LUA_TLNGSTR: { >> luaM_freemem(L, o, sizestring(gco2ts(o))); >> break; >> >> Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c >> ============================================================================== >> --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c Thu Feb 22 00:42:12 2018 (r329769) >> +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c Thu Feb 22 00:46:24 2018 (r329770) >> @@ -475,6 +475,7 @@ static int llex (LexState *ls, SemInfo *seminfo) { >> else if (!lisdigit(ls->current)) return '.'; >> /* else go through */ > ^^^^^^^^^^^^^^^^^^^^^^^ Wasnt this already marked, perhaps in the > wrong place with the wrong string? As I understand GCC 7 parses comments like that to decide whether generate warnings or not, but this informal text is out of his understanding. -- Alexander Motin