From owner-cvs-all  Sat Feb  1  9:12:22 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2104137B401; Sat,  1 Feb 2003 09:12:21 -0800 (PST)
Received: from out4.mx.nwbl.wi.voyager.net (out4.mx.nwbl.wi.voyager.net [169.207.3.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8D9DC43F75; Sat,  1 Feb 2003 09:12:20 -0800 (PST)
	(envelope-from silby@silby.com)
Received: from [10.1.1.6] (d19.as21.nwbl0.wi.voyager.net [169.207.138.147])
	by out4.mx.nwbl.wi.voyager.net (Postfix) with ESMTP
	id D9EDDC8071; Sat,  1 Feb 2003 11:11:43 -0600 (CST)
Date: Sat, 1 Feb 2003 11:19:45 -0600 (CST)
From: Mike Silbersack <silby@silby.com>
To: Tom Rhodes <trhodes@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, "" <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/usb umass.c usbdevs usbdevs.h   
 usbdevs_data.h
In-Reply-To: <20030201093302.52f3d3e9.trhodes@FreeBSD.org>
Message-ID: <20030201111901.G4155-100000@patrocles.silby.com>
References: <200301312234.h0VMYHev032837@repoman.freebsd.org>   
 <20030131201657.R5899-100000@patrocles.silby.com> <20030201093302.52f3d3e9.trhodes@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


The fix should be easy.  The code in -current looked correct, but you
somehow applied the patch to -stable in a totally incorrect fashion.  Make
sure you use unidiffs or context diffs in the future, that should prevent
such problems.

Mike "Silby" Silbersack

On Sat, 1 Feb 2003, Tom Rhodes wrote:

> I've completely reverted the commit until such a time I can look over
> it.  Sorry about the breakage.  :)
>
> --
> Tom Rhodes
>
>
>
> On Fri, 31 Jan 2003 20:17:45 -0600 (CST)
> Mike Silbersack <silby@silby.com> wrote:
>
> >
> > I reverted the changes in umass.c, please commit the correct code
> > changes at your earliest possible convenience.
> >
> > On Fri, 31 Jan 2003, Tom Rhodes wrote:
> >
> > > trhodes     2003/01/31 14:34:17 PST
> > >
> > >   Modified files:        (Branch: RELENG_4)
> > >     sys/dev/usb          umass.c usbdevs usbdevs.h usbdevs_data.h
> > >   Log:
> > >   MFC:  Add support for the Trek Thumbdrive 8MB USB Drive.
> > >
>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message