From owner-cvs-all@FreeBSD.ORG Sat Apr 19 22:59:47 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCB9D1065671 for ; Sat, 19 Apr 2008 22:59:47 +0000 (UTC) (envelope-from cokane@cokane.org) Received: from QMTA07.emeryville.ca.mail.comcast.net (qmta07.emeryville.ca.mail.comcast.net [76.96.30.64]) by mx1.freebsd.org (Postfix) with ESMTP id AD6FC8FC21 for ; Sat, 19 Apr 2008 22:59:46 +0000 (UTC) (envelope-from cokane@cokane.org) Received: from OMTA06.emeryville.ca.mail.comcast.net ([76.96.30.51]) by QMTA07.emeryville.ca.mail.comcast.net with comcast id FPwx1Z00216AWCUA70cw00; Sat, 19 Apr 2008 22:42:11 +0000 Received: from discordia ([24.60.135.75]) by OMTA06.emeryville.ca.mail.comcast.net with comcast id Fajk1Z00C1dmTCQ8S00000; Sat, 19 Apr 2008 22:43:46 +0000 X-Authority-Analysis: v=1.0 c=1 a=hqFkFEcCLQ8A:10 a=6I5d2MoRAAAA:8 a=vexJx0-XYxPer3dY9M4A:9 a=nAqcQfau7FFumozTyZwA:7 a=JrQmf68EmOqtu_pzVdsoozWmLF8A:4 a=LY0hPdMaydYA:10 Received: by discordia (Postfix, from userid 103) id A962B1636F9; Sat, 19 Apr 2008 18:43:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by discordia (Postfix) with ESMTP id 519BA1636F8; Sat, 19 Apr 2008 18:43:30 -0400 (EDT) From: Coleman Kane To: Robert Watson In-Reply-To: <47D9CC76.9020000@FreeBSD.org> References: <200803132015.m2DKFndQ008412@repoman.freebsd.org> <20080313215520.X83983@fledge.watson.org> <47D9CC76.9020000@FreeBSD.org> Content-Type: text/plain Date: Sat, 19 Apr 2008 18:43:06 -0400 Message-Id: <1208644987.4453.10.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_softdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Apr 2008 22:59:47 -0000 On Thu, 2008-03-13 at 20:53 -0400, Coleman Kane wrote: > Robert Watson wrote: > > > > On Thu, 13 Mar 2008, Coleman Kane wrote: > > > >> cokane 2008-03-13 20:15:49 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/ufs/ffs ffs_softdep.c > >> Log: > >> Replace the non-MPSAFE timeout(9) API in ffs_softdep.c with the MPSAFE > >> callout_* API (e.g. callout_init_mtx(9)). This was one of the numerous > >> items on the http://wiki.freebsd.org/SMPTODO list. > >> > >> Reviewed by: imp, obrien, jhb > >> MFC after: 1 week > > > > I might give this one a month to MFC rather than a week -- it can take > > a while for bugs in this sort of thing to get diagnosed, especially > > with lots of other changes in the tree at the same time relating to > > schedulers, etc. > > > > Robert N M Watson > > Computer Laboratory > > University of Cambridge > > > Thanks, that's a good idea. I'll hold onto it for a month before it goes > into RELENG_7. > > -- > Coleman > Robert, About a month later... I haven't gotten any problem reports from this. One question: do you know if this applies to RELENG_6 as well? -- Coleman Kane