Date: Thu, 16 Jul 2015 02:39:32 +0300 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r392209 - in head/devel: . p5-Minilla Message-ID: <20150715233932.GF6337@hades.panopticon> In-Reply-To: <1F084648031C9C61AABC041D@atuin.in.mat.cc> References: <201507152017.t6FKHElA056017@svnmir.geo.freebsd.org> <F55E1B42FC419AF2D5795884@atuin.in.mat.cc> <20150715204943.GK97479@hades.panopticon> <1F084648031C9C61AABC041D@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
* Mathieu Arnold (mat@FreeBSD.org) wrote:
> |> | +RUN_DEPENDS:= ${BUILD_DEPENDS}
> |>
> |> Please, do *not* use := for depends, it is wrong.
> |> <https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.h
> |> tml>
> |
> | First, mail submitter, not me.
>
> I'm sorry, but no, you are the one committing it, thus, you are responsible
> for it to be up to our standards.
Yes, and I see nothing wrong with it.
> | Next, handbook doesn't say anything against :=.
>
> That is right, but the handbook tells you to do something else, that is,
> use a third variable, I'll add a bit about never using := tomorrow.
The way it is now it's nothing more than a mere suggestion.
--
Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150715233932.GF6337>