Date: Fri, 10 Oct 2014 11:06:04 -0400 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: Baptiste Daroussin <bapt@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Ian Lepore <ian@freebsd.org> Subject: Re: svn commit: r272808 - head/include/rpcsvc Message-ID: <CAJ5_RoC_0vB30CwWqx0OTJqxmB4=CQuW8rY4MMJbDBMPBLzU8w@mail.gmail.com> In-Reply-To: <20141010145043.GI19486@ivaldir.etoilebsd.net> References: <201410090658.s996wYOr096351@svn.freebsd.org> <1412949811.12052.270.camel@revolution.hippie.lan> <20141010145043.GI19486@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 10, 2014 at 10:50 AM, Baptiste Daroussin <bapt@freebsd.org> wrote: > On Fri, Oct 10, 2014 at 08:03:31AM -0600, Ian Lepore wrote: > > On Thu, 2014-10-09 at 06:58 +0000, Baptiste Daroussin wrote: > > > Author: bapt > > > Date: Thu Oct 9 06:58:33 2014 > > > New Revision: 272808 > > > URL: https://svnweb.freebsd.org/changeset/base/272808 > > > > > > -%#define ENTRY_VAL(obj, col) \ > > > - (obj)->EN_data.en_cols.en_cols_val[col].ec_value.ec_value_val > > > -%#define ENTRY_LEN(obj, col) \ > > > - (obj)->EN_data.en_cols.en_cols_val[col].ec_value.ec_value_len > > > +%#define ENTRY_VAL(obj, col) > (obj)->EN_data.en_cols.en_cols_val[col].ec_value.ec_value_val > > > +%#define ENTRY_LEN(obj, col) > (obj)->EN_data.en_cols.en_cols_val[col].ec_value.ec_value_len > > > % > > > %#ifdef __cplusplus > > > %} > > > > > > > How does unwrapping these lines so that they're longer than the style(9) > > limits fix the build? > > > > (I'm not a fan of 80-column limits, it's a rule that needs to die die > > die. I'm just curious what the actual fix is here.) > > > > to be honnest here I don't know how rpcgen passes lines to cpp but recent > GNU cpp > are failing because of that, looking at dragonfly I have seen they fixed > the > same way. > rpcgen accpets cpp syntax for including other snippets as rpcgen input, but also needs to keep the ability to output cpp directives in the generated code. The '%' prefix is a sigil that the directive is to be skipped by rpcgen and instead emitted to the generated code. I assume that there was a bug in the handling of continuation lines in this context which causes things to be confused, but don't know the details of that, just what's "supposed to be" going on. -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoC_0vB30CwWqx0OTJqxmB4=CQuW8rY4MMJbDBMPBLzU8w>