From owner-cvs-all@FreeBSD.ORG Sat Oct 29 05:52:18 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A043F16A41F; Sat, 29 Oct 2005 05:52:18 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3244E43D46; Sat, 29 Oct 2005 05:52:18 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9T5qIwi098557; Sat, 29 Oct 2005 05:52:18 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9T5qIcZ098556; Sat, 29 Oct 2005 05:52:18 GMT (envelope-from imp) Message-Id: <200510290552.j9T5qIcZ098556@repoman.freebsd.org> From: Warner Losh Date: Sat, 29 Oct 2005 05:52:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pci pci.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Oct 2005 05:52:18 -0000 imp 2005-10-29 05:52:18 UTC FreeBSD src repository Modified files: sys/dev/pci pci.c Log: MFp4: When doing lazy allocation, it turns out that we need to record the actual resource values we received from the system rather than the range we requested. Since we request a range starting at 0, we would record that number. Later, since this == 0, we'd allocate again. However, we wouldn't write the new resource into the BAR. This resulted in a resource leak as well as a BAR that couldn't access the resource at all since rman_get_start, et al, were wrong. MFC After: 1 week (assuming RELENG_6 is open for business) Revision Changes Path 1.303 +3 -0 src/sys/dev/pci/pci.c