Date: Sat, 29 Jul 2006 22:38:50 +0200 From: Stefan Farfeleder <stefanf@FreeBSD.org> To: "Simon L. Nielsen" <simon@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libmp mpasbn.c Message-ID: <20060729203850.GA79580@wombat.fafoe.narf.at> In-Reply-To: <20060729110923.GA1085@zaphod.nitro.dk> References: <200607282300.k6SN0Gdn005489@repoman.freebsd.org> <20060729061426.GA79029@wombat.fafoe.narf.at> <20060729110923.GA1085@zaphod.nitro.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 29, 2006 at 01:09:24PM +0200, Simon L. Nielsen wrote: > On 2006.07.29 08:14:27 +0200, Stefan Farfeleder wrote: > > On Fri, Jul 28, 2006 at 11:00:16PM +0000, Simon L. Nielsen wrote: > > > simon 2006-07-28 23:00:16 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > lib/libmp mpasbn.c > > > Log: > > > Do not put BN_CTX structures on the stack, but instead allocate them > > > runtime using BN_CTX_new(). This is done since in OpenSSL 0.9.7e we > > > can only allocate BN_CTX on the stack by including an internal OpenSSL > > > header file, and in OpenSSL 0.9.8 BN_CTX is entirely opaque, so having > > > it on the stack is not possible at all. > > > > > > This is done as preparation for OpenSSL 0.9.8b import. > > > > It might be preferable to pass the allocated BN_CTXs to _mdiv(), > > _mult() and _sdiv() because then msqrt() would have to call > > BN_CTX_new() only once. > > Sounds like a good idea. How about the attached patch? Thanks, looks good.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060729203850.GA79580>