Date: Thu, 19 Jan 2017 23:35:44 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Xin Li <delphij@delphij.net> Cc: cem@freebsd.org, Antoine Brodin <antoine@freebsd.org>, d@delphij.net, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312404 - head/usr.bin/sed Message-ID: <9518E870-57E8-47F8-ACEA-5BBDB3B6C0E0@gmail.com> In-Reply-To: <2e5e7d42-9faa-957f-1a63-a10b91459985@delphij.net> References: <201701190801.v0J81ZG9008267@repo.freebsd.org> <CAALwa8neni57SPZAo4jW8wKu-Up0-M=weR31WtndzXdW2_jKmQ@mail.gmail.com> <CAG6CVpUZL13ujKcOjsDfcgg7wNztRK5OHH7BQADAkN_hD-d2pQ@mail.gmail.com> <2e5e7d42-9faa-957f-1a63-a10b91459985@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_2533D595-5E8D-4E31-88BF-7748A70946BD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 19, 2017, at 22:59, Xin Li <delphij@delphij.net> wrote: =E2=80=A6 > There are other issues with previous behavior, for instance, the file > would inherit permissions from the symlink itself, while a more = sensible > behavior would be to use the permissions on the symlink target. >=20 > But I think it's reasonable to revert for now and do a exp-run so we > know what would be broken. Personally I have been running with this = for > a year and that made me thought it's safe :) I think the lstat=E2=80=99s the incorrect part now =E2=80=94 should open = with O_NONBLOCK|O_RDONLY and fstat be used instead? Thanks! -Ngie --Apple-Mail=_2533D595-5E8D-4E31-88BF-7748A70946BD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYgb3QAAoJEPWDqSZpMIYVqF4QAKn/QYQUPafPTuBcluCoJmKW /3IycZByqWXf/COMO2sbOtdbuXtWQyLMuWhKSoIr+sdcNiz/Xwc+Bf2eAbsrB9h1 gR5AyMXppJEgjGuowj05+sxvtRhmB5t7U7wK4iLub5pO8CInBDXYD1U4DcqJBoMu sRtgUnDKBV4oozzV4lX/qvbiuVMhxnXV/sstpBjZ9cLag45wK9RJ/uBlKKgNmr/j hS9PUzhYRNQucC9rQo+goTVRfpH3RQqX8df7MZvs8E2BmRgDp0ky1suR9cV6YV9c y0QoGuWA0MIuOdn4Xnr0mvQH8h2CFjSTcMHpWCGl8RBa3+VjyV6NdMmDapFM4zcV 5BZGb1syWKSAuV4tGWSrAhBjvM69/9VXiO4u8WEJ726ENnkNvayhZDWdvprmB7OC Vb3Ce+xbpdhGR9mCrBpjwX50ET8qfQ/u7lJawjwEgwNW5CtF7UoLegNUzlIrRc55 GC4MDahUVTIbOINZRE+ZxNCg0cXEp7pAAMhPNDZFnn4o4an4q5Sz2C3GF0oWgiob +q1774f+sR4TU3c0/hn4TfmfMlseCrK7QDbKg5KV2zANk7B/RDfO6WQuliOtDBPe X5nIOBcnT+xHONelAiTmWNuv+0PofzO1gL4A62FJpnZfdlQH6UnzeNjWB2ia55W/ 8R6NUyzFy/DRGOLvCpdi =XYHI -----END PGP SIGNATURE----- --Apple-Mail=_2533D595-5E8D-4E31-88BF-7748A70946BD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9518E870-57E8-47F8-ACEA-5BBDB3B6C0E0>