From owner-svn-src-all@freebsd.org Fri Jan 20 07:35:46 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1675FCB9F1E; Fri, 20 Jan 2017 07:35:46 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D598914AD; Fri, 20 Jan 2017 07:35:45 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x244.google.com with SMTP id e4so4945054pfg.0; Thu, 19 Jan 2017 23:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=l6SIuiQZ9EBBl2UYiu8R+gZpnaJhYHgjcjbCdeLj3vE=; b=Y9y6efFS2BGKmOy+zmLR7cpKz6HU5uQ76vraQJnCxC9hk/P3WuhggqDexw3yVrLaY3 sqGkrzzwm9u/I5d9i98NKd8SWG/oXSqMDVWYCdCTgA9yNxKpK963Kn1WGXC/9EM7QGJu Pvr4yljMDjI2a3yEaVo4V2rFc+i5K+Fa9otDX8JXVom83Ft2ayuk1RdKCIOTejHyT8Av GFP7kyPVe2iry1l7T2cYkYiuN0Kz/bX6dOr+Vspr798NOwzfO2K8nrJQ4Wa1BmuFnA+1 5i2vQLXRGuEye6bTyfCAegOwWfUnPxHZybnk7fNbCxBFZHOoQjnc1yf37fx86MyZLqLz VXjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=l6SIuiQZ9EBBl2UYiu8R+gZpnaJhYHgjcjbCdeLj3vE=; b=r/P1nizhuX5Yyv7IYsWAw+1DGKyr705LzIwaRqZheM/1Gh7bkLTyW2RPr4+PSdxZV7 8modl6BmJgChvoFPBlqlj9Q3CvYWHbxmcqeGG1es5QjjHYB30s6bMPJ2VbaZ1DvUsmK8 bsZqWZHp/lh5eQk5JapOmmYFo+kE/L6/XIdXQjZfd0eHwimkHogVEAt0xY/d3PfkyYDW VMxGT1pfHpPPcay4C+xZmiqe8IJDEuBcuy/PVhcx6AcOFQaMxvk2fkXkbp8YoRQrOCBK 0JCJW6CtUau2uaBh2S3pFr3qc5+tJBUHT6EHSg0c87i9VdtBUdQ7YZ0oYQYhKij6+VU8 p3WA== X-Gm-Message-State: AIkVDXIhou+Z7u4gAaZ7pXRWMxgHligflpIp9rr6S7WI2RGvISTvl8TC5UVxe/VgqI/OEw== X-Received: by 10.99.65.1 with SMTP id o1mr14990938pga.93.1484897745518; Thu, 19 Jan 2017 23:35:45 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id y184sm13904163pfg.86.2017.01.19.23.35.44 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Jan 2017 23:35:44 -0800 (PST) Subject: Re: svn commit: r312404 - head/usr.bin/sed Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_2533D595-5E8D-4E31-88BF-7748A70946BD"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <2e5e7d42-9faa-957f-1a63-a10b91459985@delphij.net> Date: Thu, 19 Jan 2017 23:35:44 -0800 Cc: cem@freebsd.org, Antoine Brodin , d@delphij.net, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <9518E870-57E8-47F8-ACEA-5BBDB3B6C0E0@gmail.com> References: <201701190801.v0J81ZG9008267@repo.freebsd.org> <2e5e7d42-9faa-957f-1a63-a10b91459985@delphij.net> To: Xin Li X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 07:35:46 -0000 --Apple-Mail=_2533D595-5E8D-4E31-88BF-7748A70946BD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 19, 2017, at 22:59, Xin Li wrote: =E2=80=A6 > There are other issues with previous behavior, for instance, the file > would inherit permissions from the symlink itself, while a more = sensible > behavior would be to use the permissions on the symlink target. >=20 > But I think it's reasonable to revert for now and do a exp-run so we > know what would be broken. Personally I have been running with this = for > a year and that made me thought it's safe :) I think the lstat=E2=80=99s the incorrect part now =E2=80=94 should open = with O_NONBLOCK|O_RDONLY and fstat be used instead? Thanks! -Ngie --Apple-Mail=_2533D595-5E8D-4E31-88BF-7748A70946BD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYgb3QAAoJEPWDqSZpMIYVqF4QAKn/QYQUPafPTuBcluCoJmKW /3IycZByqWXf/COMO2sbOtdbuXtWQyLMuWhKSoIr+sdcNiz/Xwc+Bf2eAbsrB9h1 gR5AyMXppJEgjGuowj05+sxvtRhmB5t7U7wK4iLub5pO8CInBDXYD1U4DcqJBoMu sRtgUnDKBV4oozzV4lX/qvbiuVMhxnXV/sstpBjZ9cLag45wK9RJ/uBlKKgNmr/j hS9PUzhYRNQucC9rQo+goTVRfpH3RQqX8df7MZvs8E2BmRgDp0ky1suR9cV6YV9c y0QoGuWA0MIuOdn4Xnr0mvQH8h2CFjSTcMHpWCGl8RBa3+VjyV6NdMmDapFM4zcV 5BZGb1syWKSAuV4tGWSrAhBjvM69/9VXiO4u8WEJ726ENnkNvayhZDWdvprmB7OC Vb3Ce+xbpdhGR9mCrBpjwX50ET8qfQ/u7lJawjwEgwNW5CtF7UoLegNUzlIrRc55 GC4MDahUVTIbOINZRE+ZxNCg0cXEp7pAAMhPNDZFnn4o4an4q5Sz2C3GF0oWgiob +q1774f+sR4TU3c0/hn4TfmfMlseCrK7QDbKg5KV2zANk7B/RDfO6WQuliOtDBPe X5nIOBcnT+xHONelAiTmWNuv+0PofzO1gL4A62FJpnZfdlQH6UnzeNjWB2ia55W/ 8R6NUyzFy/DRGOLvCpdi =XYHI -----END PGP SIGNATURE----- --Apple-Mail=_2533D595-5E8D-4E31-88BF-7748A70946BD--