From owner-cvs-src@FreeBSD.ORG Mon Mar 1 12:57:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEE2616A4D0 for ; Mon, 1 Mar 2004 12:57:36 -0800 (PST) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF35143D45 for ; Mon, 1 Mar 2004 12:57:36 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 9057 invoked from network); 1 Mar 2004 20:57:36 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 1 Mar 2004 20:57:36 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i21KvQ29075983; Mon, 1 Mar 2004 15:57:28 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Scott Long Date: Mon, 1 Mar 2004 14:01:36 -0500 User-Agent: KMail/1.6 References: <200402290926.i1T9Q1mv041844@repoman.freebsd.org> In-Reply-To: <200402290926.i1T9Q1mv041844@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200403011401.36326.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/en midway.c src/sys/dev/hatm if_hatm.c src/sys/dev/patm if_patm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2004 20:57:37 -0000 On Sunday 29 February 2004 04:26 am, Scott Long wrote: > scottl 2004/02/29 01:26:01 PST > > FreeBSD src repository > > Modified files: > sys/dev/en midway.c > sys/dev/hatm if_hatm.c > sys/dev/patm if_patm.c > Log: > All three of these drivers abused cv_waitq_empty in the same way by > spinning on it in hopes of making sure that the waitq was empty before > going on. This wasn't needed and probably never would have worked as > intended. Now that cv_waitq_empty() and friends are gone, the code in > these drivers that spins on it can go away too. This should unbreak LINT. > > Discussed with: kan Thanks. Sorry for breaking the build. :( -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org