Date: Sun, 9 Dec 2007 14:05:59 -0600 From: Brooks Davis <brooks@freebsd.org> To: Doug Barton <dougb@freebsd.org> Cc: Gordon M Tetlow <tetlowgm@mac.com>, freebsd-arch@freebsd.org Subject: Re: Should libgssapi be hidden behind the MK_KERBEROS knob? Message-ID: <20071209200559.GA2444@lor.one-eyed-alien.net> In-Reply-To: <475B2BD1.7000303@FreeBSD.org> References: <4759DC08.9070600@FreeBSD.org> <20071208163857.GC91919@lor.one-eyed-alien.net> <B6258346-EB1D-451B-9D71-6497F3781344@mac.com> <475B2BD1.7000303@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4Ckj6UjgE2iN1+kY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Dec 08, 2007 at 03:42:09PM -0800, Doug Barton wrote:
> Gordon M Tetlow wrote:
> >=20
> > On Dec 8, 2007, at 8:38 AM, Brooks Davis wrote:
> >=20
> >> On Fri, Dec 07, 2007 at 03:49:28PM -0800, Doug Barton wrote:
> >>> If there is a better list for this, don't hesitate to let me know.
> >>>
> >>> I use WITHOUT_KERBEROS=3Dtrue in /etc/{make|src}.conf, since I don't
> >>> need or use it. However, this leads to a problem with building the
> >>> kdelibs3 port. The configure script looks for the presence of
> >>> libgssapi and the associated headers, and takes that to mean that
> >>> kerberos is available, and sets things up accordingly. This causes
> >>> the build to fail when it tries to actually link something to a
> >>> kerberos library.
> >>>
> >>> I realize that GSS can be used for other things besides kerberos, but
> >>> are we really losing anything by hiding them both under the same knob?
> >>> If the answer to that is yes, is there any objection to a WITHOUT_GSS
> >>> knob?
> >>
> >> We wouldn't loose anything today, but a without GSS knob makes more
> >> sense to me. There's at least one other GSS system in fairly wide use
> >> in the high performance computing world today.
> >=20
> > How about WITHOUT_KERBEROS implies WITHOUT_GSSAPI unless people
> > specifically ask for GSSAPI? Is that too obscure?
>=20
> That sounds totally reasonable. How does the attached look?
Seems fine to me.
-- Brooks
> Index: lib/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /usr/local/ncvs/src/lib/Makefile,v
> retrieving revision 1.226
> diff -u -r1.226 Makefile
> --- lib/Makefile 17 Nov 2007 21:29:02 -0000 1.226
> +++ lib/Makefile 8 Dec 2007 23:24:47 -0000
> @@ -31,7 +31,7 @@
> libbegemot ${_libbluetooth} libbsnmp libbz2 \
> libcalendar libcam libcompat libdevinfo libdevstat libdisk \
> libedit libexpat libfetch libftpio libgeom ${_libgpib} \
> - libgssapi libipsec \
> + ${_libgssapi} libipsec \
> ${_libipx} libkiconv libmagic libmemstat ${_libmilter} ${_libmp} \
> ${_libncp} ${_libngatm} libopie libpam libpcap \
> libpmc ${_libkse} librt ${_libsdp} ${_libsm} ${_libsmb} \
> @@ -62,6 +62,14 @@
> _libsdp=3D libsdp
> .endif
> =20
> +.if ${MK_KERBEROS} !=3D "no"
> +_libgssapi=3D libgssapi
> +.else
> +.if ${MK_GSSAPI} =3D "yes"
> +_libgssapi=3D libgssapi
> +.endif
> +.endif
> +
> .if ${MK_IPX} !=3D "no"
> _libipx=3D libipx
> .endif
> Index: share/man/man5/src.conf.5
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /usr/local/ncvs/src/share/man/man5/src.conf.5,v
> retrieving revision 1.20
> diff -u -r1.20 src.conf.5
> --- share/man/man5/src.conf.5 19 Oct 2007 14:03:05 -0000 1.20
> +++ share/man/man5/src.conf.5 8 Dec 2007 23:40:23 -0000
> @@ -288,6 +288,10 @@
> .\" from FreeBSD: src/tools/build/options/WITHOUT_GROFF,v 1.1 2006/03/21=
07:50:49 ru Exp
> Set to not build
> .Xr groff 1 .
> +.It Va WITH_GSSAPI
> +Set to build libgssapi when
> +.Va WITHOUT_KERBEROS
> +is set.
> .It Va WITH_HESIOD
> .\" from FreeBSD: src/tools/build/options/WITH_HESIOD,v 1.1 2006/03/21 0=
7:50:50 ru Exp
> Set to build Hesiod support.
> @@ -347,6 +351,10 @@
> .Bl -item -compact
> .It
> .Va WITHOUT_KERBEROS_SUPPORT
> +.It
> +.Va WITHOUT_GSSAPI
> +(unless overridden by
> +.Va WITH_GSSAPI )
> .El
> .It Va WITHOUT_KERBEROS_SUPPORT
> .\" from FreeBSD: src/tools/build/options/WITHOUT_KERBEROS_SUPPORT,v 1.1=
2006/03/21 07:50:50 ru Exp
> Index: share/mk/bsd.own.mk
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /usr/local/ncvs/src/share/mk/bsd.own.mk,v
> retrieving revision 1.69
> diff -u -r1.69 bsd.own.mk
> --- share/mk/bsd.own.mk 20 Oct 2007 19:01:49 -0000 1.69
> +++ share/mk/bsd.own.mk 8 Dec 2007 23:29:05 -0000
> @@ -381,6 +381,7 @@
> #
> .for var in \
> BIND_LIBS \
> + GSSAPI \
> HESIOD \
> IDEA
> .if defined(WITH_${var}) && defined(WITHOUT_${var})
> _______________________________________________
> freebsd-arch@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-arch
> To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"
--4Ckj6UjgE2iN1+kY
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)
iD8DBQFHXEqmXY6L6fI4GtQRAmgCAKDgfZeVIiAlZSbDZ7nHdlxlFjk71wCfSAvS
OTnBXQDdudGTsxpAH9y+XGc=
=Zz2M
-----END PGP SIGNATURE-----
--4Ckj6UjgE2iN1+kY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071209200559.GA2444>