From owner-svn-src-all@freebsd.org Thu Oct 17 23:41:04 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7623A1605F3; Thu, 17 Oct 2019 23:41:04 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46vQf82WcTz3NWf; Thu, 17 Oct 2019 23:41:04 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 32CD2260298; Thu, 17 Oct 2019 17:53:55 +0200 (CEST) Subject: Re: svn commit: r353635 - in head/sys: netinet netinet6 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Gleb Smirnoff References: <201910160911.x9G9BonH076337@repo.freebsd.org> <20191016165722.GU4086@FreeBSD.org> <138998a2-b304-fbe3-065d-e1df0a09af14@selasky.org> <20191017150822.GY4086@FreeBSD.org> From: Hans Petter Selasky Message-ID: <76f19c59-8ea5-b80a-a7b2-6f7df9030851@selasky.org> Date: Thu, 17 Oct 2019 17:51:28 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191017150822.GY4086@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46vQf82WcTz3NWf X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Oct 2019 23:41:04 -0000 On 2019-10-17 17:08, Gleb Smirnoff wrote: > On Wed, Oct 16, 2019 at 10:46:44PM +0200, Hans Petter Selasky wrote: > H> > as far as I remember I was against this changeset and I had > H> > several other developers agreed that this should be fixed in > H> > different way. Why did you proceed with checking it in? :( > H> > H> Hi Gleb, > H> > H> This issue has been discussed in-depth at various transport meetings and > H> we have agreed on a solution. > > Is the list of people who agreed longer than "Reviewed by" list? Yes. > > H> Are you seeing something broken as of this patch? > > As I already explained, first, we are dropping absolutely legitimate > packets. At the time of arrival there were nothing wrong about them. > This is idelogically wrong from viewpoint of abstract network stack. No packets are dropped. This was the initial version of my patch. Please re-read the history of the differential revision. > Second, the problem should be fixed in a different way: when we put > packets on the queue, we should take all important values out of the > ifnet and store them on queue entry. No, this won't work. Sometimes you need to send an ICMP error message back, but to which interface? You cannot use unit-numbers (risking the packet goes to wrong interface) nor pointers, which then can point to freed memory. --HPS