From owner-freebsd-acpi@FreeBSD.ORG Wed Jun 8 11:46:18 2005 Return-Path: X-Original-To: freebsd-acpi@freebsd.org Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0640816A41C; Wed, 8 Jun 2005 11:46:18 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from mh2.centtech.com (moat3.centtech.com [207.200.51.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA00C43D48; Wed, 8 Jun 2005 11:46:17 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from [10.177.171.220] (neutrino.centtech.com [10.177.171.220]) by mh2.centtech.com (8.13.1/8.13.1) with ESMTP id j58BkHHQ097244; Wed, 8 Jun 2005 06:46:17 -0500 (CDT) (envelope-from anderson@centtech.com) Message-ID: <42A6DA72.2070105@centtech.com> Date: Wed, 08 Jun 2005 06:45:54 -0500 From: Eric Anderson User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050603 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Warner Losh References: <200506032012.j53KCC5k077879@repoman.freebsd.org> In-Reply-To: <200506032012.j53KCC5k077879@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@freebsd.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2005 11:46:18 -0000 Warner Losh wrote: > imp 2005-06-03 20:12:12 UTC > > FreeBSD src repository > > Modified files: > sys/dev/acpica acpi.c > Log: > In newbus land, ivars can only be accessed for direct child, or when > the driver has unholy private knowledge of its great-*cgrandchildren. > The ACPI allocation routine lacked such knowledge when it tried to do > a default allocation for all descendants, rather than just its > immeidate children, so would access grandchild's ivar in an unsafe > way. This could lead to a panic when devices were present which had > no addresses setup by the BIOS, but which were later allocated in a > lazy manner via pci_alloc_map. As such, only do the default > allocation adjustments for immediate children. The manner that > acpi_sysres_find accesses the resource list, used later in > acpi_alloc_resource, is safe and proper so no additional test is > needed there. > > This fixes a panic when probing an disabled ata controller on some > newer intel blades. > > Reported by: dwhite > > Revision Changes Path > 1.214 +1 -1 src/sys/dev/acpica/acpi.c Warner - I owe you a beer! I believe this commit got my Dell D610 laptop (and maybe the D600's?) to go into S3 mode, which prior to this commit it would power off the machine instead of going into S3. Now, my only problem is that when trying to come out of S3, it powers off. How do I debug that? Thanks for the commit!! Eric -- ------------------------------------------------------------------------ Eric Anderson Sr. Systems Administrator Centaur Technology A lost ounce of gold may be found, a lost moment of time never. ------------------------------------------------------------------------