Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Jan 2020 09:47:23 +0100
From:      Piotr Kubaj <pkubaj@anongoth.pl>
To:        Yuri Victorovich <yuri@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r522472 - head/science/vipster
Message-ID:  <20200109084723.GA51658@talos>
In-Reply-To: <202001090757.0097vhau096251@repo.freebsd.org>
References:  <202001090757.0097vhau096251@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--rwEMma7ioTxnRzrJ
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline

Since this will break build on all GCC architectures, can you add something like:

USES= cmake compiler

...
...

The following will probably require .include <bsd.port.pre.mk> first. You're also setting CC wrong, please see https://wiki.freebsd.org/HardcodedCCVersions

.if ${CHOSEN_COMPILER_TYPE} == clang
${YOUR_CLANG_SETUP}
.else
USE_GCC=	yes
.endif



On 20-01-09 07:57:43, Yuri Victorovich wrote:
>Author: yuri
>Date: Thu Jan  9 07:57:43 2020
>New Revision: 522472
>URL: https://svnweb.freebsd.org/changeset/ports/522472
>
>Log:
>  science/vipster: Unbreak on 120amd64 (with clang-6) by forcing the latest clang
>
>  clang-6 lacks the c++17 feature std::mmap::extract
>
>  Reported by:	fallout
>
>Modified:
>  head/science/vipster/Makefile
>
>Modified: head/science/vipster/Makefile
>==============================================================================
>--- head/science/vipster/Makefile	Thu Jan  9 07:41:39 2020	(r522471)
>+++ head/science/vipster/Makefile	Thu Jan  9 07:57:43 2020	(r522472)
>@@ -4,6 +4,7 @@ PORTNAME=	vipster
> DISTVERSIONPREFIX=	v
> DISTVERSION=	1.18b-75
> DISTVERSIONSUFFIX=	-gfa5853f
>+PORTREVISION=	1
> CATEGORIES=	science
>
> MAINTAINER=	yuri@FreeBSD.org
>@@ -12,7 +13,7 @@ COMMENT=	Crystalline and molecular structure visualisa
> LICENSE=	GPLv3
> LICENSE_FILE=	${WRKSRC}/LICENSE
>
>-USES=		cmake compiler:c++17-lang
>+USES=		cmake
> USE_GITHUB=	yes
> GH_ACCOUNT=	sgsaenger
> USE_LDCONFIG=	yes
>@@ -28,6 +29,12 @@ DESKTOP_USE=		QT=core,gui,widgets,buildtools_build,qma
>
> PYTHON_CMAKE_BOOL=	PYTHON
> PYTHON_BROKEN=		Bundles pybind11: https://github.com/sgsaenger/vipster/issues/23
>+
>+# use clang from ports because older clang (clang-6) lacks the c++17 feature std::mmap::extract
>+BUILD_DEPENDS+=	clang${LLVM_DEFAULT}:devel/llvm${LLVM_DEFAULT}
>+CPP=		clang-cpp${LLVM_DEFAULT}
>+CC=		clang${LLVM_DEFAULT}
>+CXX=		clang++${LLVM_DEFAULT}
>
> do-test:
> 	@cd ${BUILD_WRKSRC} && \

--rwEMma7ioTxnRzrJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl4W6JMACgkQelmbhSCD
nJ2dKQ/+J50Y1hgTJmV/DB1NQqMUqE5MF23EzbTkFKo0uV8exc+iNttadAF5DGfv
QN7g1qxELtKwO3UPGAROA9MnsC7Vz3T7vtxpIhJk4wKI8vw629H8y7yRGFi85FwD
Q+99rXbqfPFdC1pfhtYD1peWNewMCASSCWsNsixgivpg0A0nhPuTfuW04nLlNKju
OAX5t/HFClQwNo/G+L5+LD2rad+IclVYJDzzlmdEhCR+dkLAS21NYd+hS+n11SBo
rvOwJhrV2jDdafuhJw9iksiawiTlrS/EQ0Dnn9qQyDSrYJy+9iobtpnqUjw6qt2b
QOj9gnmmbCteAQacdBePD8lS5w2erny4Vi/T4RrQzmMYGqWX2ctc6hcvk6gTmvnz
yTb8bajW19ym5wpfujouNeAmn5qdir/LGV0S4KRm2eULQvMONOWjf/8wfZxSINHJ
kiUfQd4zERLcS47FX9iOt9rvkOuHM9qG43C/IZQabGskugCGV+7lq0I9yltqervr
p3SctuLDgjVKG+yZLKvXnwFFBuRHN3eCRqiRW/7PywQ+Gt4rjafeXS+rai9v8RK1
gqwyxolvl4+FTzE89Vg+gOihtwxxuMC8+M8mws4kDNnBTib1z1OJI6Dx0rsmkj+N
wU53aT3mqwvfa9Idru5vLwlJLBKUzhUNc63ow2sqZQR/fJZkPbs=
=cWpb
-----END PGP SIGNATURE-----

--rwEMma7ioTxnRzrJ--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200109084723.GA51658>