Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Dec 2016 15:46:18 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 215422] bhnd.ko does not build reproducibly
Message-ID:  <bug-215422-8-kL7p38MG1r@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-215422-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-215422-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215422

--- Comment #6 from commit-hook@freebsd.org ---
A commit references this bug:

Author: emaste
Date: Wed Dec 21 15:45:23 UTC 2016
New revision: 310371
URL: https://svnweb.freebsd.org/changeset/base/310371

Log:
  bhnd: remove srand() to ensure deterministic output

  r310342 fixed non-deterministic nvram_map_gen.awk output and thus a non-
  reproducible bhnd(4) build by using a unique sort key.

  Go one step further and also remove the srand() call. There's no reason
  we want non-deterministic behaviour from this script.

  PR:           215422
  Reported by:  gjb (non-reproducibility of bhnd)
  Reported by:  lidl (srand as the cause)
  Reviewed by:  landonf
  Sponsored by: The FreeBSD Foundation
  Differential Revision:        https://reviews.freebsd.org/D8857

Changes:
  head/sys/dev/bhnd/tools/nvram_map_gen.awk

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-215422-8-kL7p38MG1r>