Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Apr 2019 23:37:28 +0000 (UTC)
From:      Chuck Tuffli <chuck@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r346194 - head/usr.sbin/bhyve
Message-ID:  <201904132337.x3DNbSHA038621@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: chuck
Date: Sat Apr 13 23:37:27 2019
New Revision: 346194
URL: https://svnweb.freebsd.org/changeset/base/346194

Log:
  Revert r345171 pending review
  
  Backing out commit pending further discussion on the PCIe version
  supported by pseudo (i.e. emulated) devices. See Differential for
  details.
  
  Reviewed by:	imp
  Approved by:	imp (mentor)
  Differential Revision:	https://reviews.freebsd.org/D19580

Modified:
  head/usr.sbin/bhyve/pci_emul.c

Modified: head/usr.sbin/bhyve/pci_emul.c
==============================================================================
--- head/usr.sbin/bhyve/pci_emul.c	Sat Apr 13 23:32:28 2019	(r346193)
+++ head/usr.sbin/bhyve/pci_emul.c	Sat Apr 13 23:37:27 2019	(r346194)
@@ -953,10 +953,7 @@ pci_emul_add_pciecap(struct pci_devinst *pi, int type)
 	bzero(&pciecap, sizeof(pciecap));
 
 	pciecap.capid = PCIY_EXPRESS;
-	pciecap.pcie_capabilities = PCIECAP_VERSION | type;
-	/* Devices starting with version 1.1 must set the RBER bit */
-	if (PCIECAP_VERSION >= 1)
-		pciecap.dev_capabilities = PCIEM_CAP_ROLE_ERR_RPT;
+	pciecap.pcie_capabilities = PCIECAP_VERSION | PCIEM_TYPE_ROOT_PORT;
 	pciecap.link_capabilities = 0x411;	/* gen1, x1 */
 	pciecap.link_status = 0x11;		/* gen1, x1 */
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904132337.x3DNbSHA038621>