Date: Thu, 25 Oct 2018 15:03:43 +0200 From: Mateusz Piotrowski <0mp@freebsd.org> To: mat@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r482963 - head/misc/exercism Message-ID: <CAD9iB3cNOzcp_UPmAxfH4Pj%2B_XtKDmaadL8dgugjN9jtRORgmA@mail.gmail.com> In-Reply-To: <20181025115917.z2h6zx5txmxkzrtj@ogg.in.absolight.net> References: <201810250948.w9P9mGSb099015@repo.freebsd.org> <20181025115917.z2h6zx5txmxkzrtj@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Thu, 25 Oct 2018 at 13:59, Mathieu Arnold <mat@freebsd.org> wrote: > On Thu, Oct 25, 2018 at 09:48:16AM +0000, Mateusz Piotrowski wrote: > > - Use DISTVERSION instead of PORTVERSION as suggested by the handbook. > > This should not have happened, the version did not change. > Hmmm, could you please tell me more about this? I thought that it is just a style change because the final value of PORTVERSION has not changed. > > - Move GH_TUPLE out of the USE* section. > > This is wrong, see: > > https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-uses.html Thank you for pointing this out. https://reviews.freebsd.org/D17699 Thanks, Mathieu! Mateusz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD9iB3cNOzcp_UPmAxfH4Pj%2B_XtKDmaadL8dgugjN9jtRORgmA>