From owner-cvs-all@FreeBSD.ORG Fri Dec 17 11:21:00 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F24D416A4CE; Fri, 17 Dec 2004 11:20:59 +0000 (GMT) Received: from jc.ngo.org.uk (jc.ngo.org.uk [69.55.225.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A10043D54; Fri, 17 Dec 2004 11:20:59 +0000 (GMT) (envelope-from nik@crf-consulting.co.uk) Received: from crf-consulting.co.uk (82-44-220-218.cable.ubr10.haye.blueyonder.co.uk [82.44.220.218]) by jc.ngo.org.uk (8.12.11/8.13.1) with ESMTP id iBHBKul5088952; Fri, 17 Dec 2004 03:20:58 -0800 (PST) (envelope-from nik@crf-consulting.co.uk) Received: from clan.nothing-going-on.org (clan.nothing-going-on.org [192.168.1.20]) by crf-consulting.co.uk (8.13.1/8.12.9) with ESMTP id iBHBKtiY037397; Fri, 17 Dec 2004 11:20:55 GMT (envelope-from nik@catkin) Received: from clan.nothing-going-on.org (localhost [127.0.0.1]) iBHBKtLT063661; Fri, 17 Dec 2004 11:20:55 GMT (envelope-from nik@clan.nothing-going-on.org) Received: (from nik@localhost) by clan.nothing-going-on.org (8.13.1/8.13.1/Submit) id iBHBKsap063660; Fri, 17 Dec 2004 11:20:54 GMT (envelope-from nik) Date: Fri, 17 Dec 2004 11:20:54 +0000 From: Nik Clayton To: Ruslan Ermilov Message-ID: <20041217112053.GK17158@clan.nothing-going-on.org> References: <200412161955.iBGJtvIO060191@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="08ATZu8fEq0x2T3M" Content-Disposition: inline In-Reply-To: <200412161955.iBGJtvIO060191@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Organization: FreeBSD Project cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2004 11:21:00 -0000 --08ATZu8fEq0x2T3M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Ruslan, On Thu, Dec 16, 2004 at 07:55:57PM +0000, Ruslan Ermilov wrote: > Previous revision didn't fix all cases. For example, > testing for variables that are always defined (e.g., > "make -V CC") would still print a false warning. Fix > this by only passing a submake the MAKEOBJDIRPREFIX=3D* > argument if it was present. As a result, we loose > the check for -DMAKEOBJDIRPREFIX, or an esoteric > "MAKEOBJDIRPREFIX =3D foo" (with embedded spaces), but > these are unorthodox enough to not care about them. > =20 > The make(1) bug mentioned in the previous revision > was just fixed in make/main.c,v 1.109. Do you have test cases for these issues? They should be added to=20 tools/regression/usr.bin/make. N --=20 FreeBSD: The Power to Serve http://www.freebsd.org/ (__) FreeBSD Documentation Project http://www.freebsd.org/docproj/ \\\'',) \/ \= ^ --- 15B8 3FFC DDB4 34B0 AA5F 94B7 93A8 0764 2C37 E375 --- .\._/= _) --08ATZu8fEq0x2T3M Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBwsEVk6gHZCw343URAqjNAJsFEJphI0Rt7Z/QLsOiWwmcY8U+ugCfZEZH DfNUKbRRnUP18+vq7NjsAS0= =ZD+A -----END PGP SIGNATURE----- --08ATZu8fEq0x2T3M--