From owner-freebsd-ports-bugs@freebsd.org Sun Aug 16 23:09:32 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2C569B9942 for ; Sun, 16 Aug 2015 23:09:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B5C071A52 for ; Sun, 16 Aug 2015 23:09:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t7GN9Wmt019726 for ; Sun, 16 Aug 2015 23:09:32 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 202375] ports-mgmt/portlint: warn about not using option helpers Date: Sun, 16 Aug 2015 23:09:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: marcus@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2015 23:09:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202375 Bug ID: 202375 Summary: ports-mgmt/portlint: warn about not using option helpers Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: feature, needs-patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: jbeich@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) Assignee: marcus@FreeBSD.org To make ports' Makefiles easier to read and review portlint should warn about conditionals that can be eliminated with option helpers. At least for new ports. For example, $ cd net/ocserv $ portlint -C WARN: Makefile: [49]: USES is defined with `+='. Consider using option helper FOO_USES instead. WARN: Makefile: [50]: LIB_DEPENDS is defined with `+='. Consider using option helper FOO_LIB_DEPENDS instead. WARN: Makefile: [52]: CONFIGURE_ARGS is defined with `+='. Consider using option helpers instead: FOO_CONFIGURE_ENABLE, FOO_CONFIGURE_WITH or FOO_CONFIGURE_ON. WARN: Makefile: [68]: PORT_OPTIONS found within *-install target. Consider using target option helper pre-install-FOO-on or post-install-FOO-on instead. WARN: Makefile: [73]: PORT_OPTIONS found within *-install target. Consider using target option helper pre-install-FOO-on or post-install-FOO-on instead. -- You are receiving this mail because: You are the assignee for the bug.