From owner-cvs-all@FreeBSD.ORG  Fri Mar 11 21:31:33 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CF86616A4CF; Fri, 11 Mar 2005 21:31:33 +0000 (GMT)
Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0E34A43D49; Fri, 11 Mar 2005 21:31:33 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j2BLVVoG004685;
	Fri, 11 Mar 2005 22:31:31 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Hajimu UMEMOTO <ume@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sat, 12 Mar 2005 06:26:14 +0900."
             <yge8y4t6fih.wl%ume@mahoroba.org> 
Date: Fri, 11 Mar 2005 22:31:31 +0100
Message-ID: <4684.1110576691@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/crypto/rijndael rijndael.h
	src/sys/dev/random hash.c yarrow.c src/sys/geom geom_aes.c
	src/sys/geom/bde g_bde.c g_bde_crypt.c g_bde_lock.c g_bde_work.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2005 21:31:34 -0000

In message <yge8y4t6fih.wl%ume@mahoroba.org>, Hajimu UMEMOTO writes:
>Hi,
>
>>>>>> On Fri, 11 Mar 2005 18:53:24 +0100
>>>>>> "Poul-Henning Kamp" <phk@phk.freebsd.dk> said:
>
>phk> You tested gbde before this commit, right ?
>
>I didn't test it actually.  Since the commit changes only inclusion of
>header file, and doesn't change any logic, I checked generated
>geom_bde.ko with old one by cmp(1) and saw there is no difference.  Is
>it insufficient?

probably.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.