Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Jun 2006 00:42:58 -0500 (CDT)
From:      Alexander Botero-Lowry <alex@foxybanana.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        mnag@FreeBSD.org
Subject:   ports/99008: [PATCH] databases/sqlite: Make thread safe support default
Message-ID:  <200606160542.k5G5gwav098795@Laptop.mine.box>
Resent-Message-ID: <200606160550.k5G5oBpL069476@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         99008
>Category:       ports
>Synopsis:       [PATCH] databases/sqlite: Make thread safe support default
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 16 05:50:11 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Alexander Botero-Lowry
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD Laptop.mine.box 6.1-STABLE FreeBSD 6.1-STABLE #0: Sat May  6 22:21:39 PDT
>Description:
- Make thread safe support default

My reason for doing this is that, as far as I know there are no significant
performance or stability concerns with regards to this switch, and it is
required by some ports. audio/xmms2 for example requires that sqlite3 be
compiled with thread safety or it can lead to media library corruption. 
Development versions (not in ports, but will hopefully be in ports in the
future) of audio/mt-daapd also require that sqlite3 be compiled thread safe.

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:

--- sqlite-3.3.6.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/sqlite3/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile	11 Jun 2006 21:43:25 -0000	1.19
+++ Makefile	16 Jun 2006 05:40:53 -0000
@@ -27,7 +27,7 @@
 EXAMPLESDIR=	${PREFIX}/share/examples/sqlite3
 
 OPTIONS=	TCLWRAPPER	"TCL wrapper for SQLITE"		off \
-		THREADS		"Enable threads support"		off \
+		THREADS		"Enable threads support"		on \
 		DEBUG		"Enable debugging & verbose explain"	off \
 		DOCS		"Building docs (depends on TCL)"	on
 
@@ -48,7 +48,7 @@
 PLIST_SUB+=		WITH_TCLWRAPPER="@comment "
 .endif
 
-.if defined(WITH_THREADS)
+.if !defined(WITHOUT_THREADS)
 CONFIGURE_ARGS+=	--enable-threadsafe
 .endif
 
--- sqlite-3.3.6.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606160542.k5G5gwav098795>