From owner-cvs-all Sun Jan 5 15:55:15 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96B0837B401; Sun, 5 Jan 2003 15:55:10 -0800 (PST) Received: from lerlaptop.lerctr.org (lerlaptop.lerctr.org [207.158.72.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id C811743EC5; Sun, 5 Jan 2003 15:55:09 -0800 (PST) (envelope-from ler@lerctr.org) Received: from localhost (localhost [127.0.0.1]) by lerlaptop.lerctr.org (8.12.6/8.12.6) with ESMTP id h05Nt5AL083245; Sun, 5 Jan 2003 17:55:06 -0600 (CST) (envelope-from ler@lerctr.org) Date: Sun, 05 Jan 2003 17:55:05 -0600 From: Larry Rosenman To: Hidetoshi Shimokawa , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, freebsd-stable@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/fwcontrol fwcontrol.8 fwcontrol.c fwcrom.c src/sys/dev/firewire firewire.c firewire.h firewirebusreg.h firewirereg.h fwcrom.c fwdev.c fwohci.c fwohci_pci.c fwohcireg.h fwohcivar.h sbp.c ... Message-ID: <22230000.1041810905@lerlaptop.lerctr.org> In-Reply-To: <200301051350.h05Do5H2030165@repoman.freebsd.org> References: <200301051350.h05Do5H2030165@repoman.freebsd.org> X-Mailer: Mulberry/3.0.0b10 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Virus-Scanned: by amavisd-milter (http://amavis.org/) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Looks like someone forgot to add: dev/firewire/fwcrom.c optional firewire to src/sys/conf/files Without it, you can't link a kernel: inking kernel.debug sbp.o: In function `sbp_alloc_target': /usr/src/sys/dev/firewire/sbp.c(.text+0x205): undefined reference to `crom_init_context' /usr/src/sys/dev/firewire/sbp.c(.text+0x23e): undefined reference to `crom_next' /usr/src/sys/dev/firewire/sbp.c(.text+0x24f): undefined reference to `crom_search_key' /usr/src/sys/dev/firewire/sbp.c(.text+0x2d4): undefined reference to `crom_init_context' /usr/src/sys/dev/firewire/sbp.c(.text+0x300): undefined reference to `crom_next' /usr/src/sys/dev/firewire/sbp.c(.text+0x311): undefined reference to `crom_search_key' *** Error code 1 Stop in /usr/obj/usr/src/sys/LERLAPTOP. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. $ I added the above line, and the kernel now links. LER --On Sunday, January 05, 2003 05:50:05 -0800 Hidetoshi Shimokawa wrote: > simokawa 2003/01/05 05:50:05 PST > > Modified files: (Branch: RELENG_4) > usr.sbin/fwcontrol fwcontrol.8 fwcontrol.c fwcrom.c > sys/dev/firewire firewire.c firewire.h firewirereg.h > fwdev.c fwohci.c fwohci_pci.c fwohcireg.h > fwohcivar.h sbp.c > sys/modules/firewire/firewire Makefile > Added files: (Branch: RELENG_4) > sys/dev/firewire fwcrom.c > Removed files: (Branch: RELENG_4) > sys/dev/firewire firewirebusreg.h > Log: > MFC: Sync FireWire driver/utility with current. > - Implement primal Configuration ROM parser. > - Support multiple LUNs for SBP-II. > - Update PCI device IDs. > - Improve phy access. > - Free allocated memory when detaching. > - Detect contigmalloc failure. > - Support suspend/resume. > - Remove unused firewirebusreg.h. > - Skip mbuf whose length is zero. > - Remove speed_map API because speed_map is obsoleted by 1394a. > > Revision Changes Path > 1.3.2.5 +22 -20 src/sys/dev/firewire/firewire.c > 1.2.2.3 +1 -1 src/sys/dev/firewire/firewire.h > 1.1.2.2 +0 -38 src/sys/dev/firewire/firewirebusreg.h (dead) > 1.1.2.3 +2 -0 src/sys/dev/firewire/firewirereg.h > 1.2.2.1 +255 -0 src/sys/dev/firewire/fwcrom.c (new) > 1.2.4.2 +0 -5 src/sys/dev/firewire/fwdev.c > 1.1.2.6 +308 -182 src/sys/dev/firewire/fwohci.c > 1.3.2.5 +82 -46 src/sys/dev/firewire/fwohci_pci.c > 1.2.2.3 +19 -15 src/sys/dev/firewire/fwohcireg.h > 1.1.2.3 +5 -1 src/sys/dev/firewire/fwohcivar.h > 1.5.2.5 +41 -15 src/sys/dev/firewire/sbp.c > 1.2.2.3 +2 -2 src/sys/modules/firewire/firewire/Makefile > 1.1.2.2 +1 -3 src/usr.sbin/fwcontrol/fwcontrol.8 > 1.1.2.2 +17 -35 src/usr.sbin/fwcontrol/fwcontrol.c > 1.1.2.2 +5 -4 src/usr.sbin/fwcontrol/fwcrom.c > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message > > -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 972-414-9812 E-Mail: ler@lerctr.org US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message