Date: Tue, 4 Jan 2011 10:30:40 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org>, Garrett Cooper <gcooper@freebsd.org> Subject: Re: svn commit: r216967 - head/usr.sbin/rtprio Message-ID: <004687DF-47EF-4468-97DB-8443A249BE00@gmail.com> In-Reply-To: <201101041322.33071.jhb@freebsd.org> References: <201101041727.p04HRHZC048894@svn.freebsd.org> <AANLkTikqR3dzNV23Ti=cDmhig93Ko3LTgLh7HCaQFv5-@mail.gmail.com> <201101041322.33071.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 4, 2011, at 10:22 AM, John Baldwin wrote: > On Tuesday, January 04, 2011 12:41:51 pm Garrett Cooper wrote: >> On Tue, Jan 4, 2011 at 9:27 AM, Konstantin Belousov <kib@freebsd.org> = wrote: >>> Author: kib >>> Date: Tue Jan 4 17:27:17 2011 >>> New Revision: 216967 >>> URL: http://svn.freebsd.org/changeset/base/216967 >>>=20 >>> Log: >>> Use errx() instead of err() in parseint. There is usually no = interesting >>> information in errno. >>>=20 >>> Noted by: Garrett Cooper <yanegomi gmail com> >>> MFC after: 1 week >>=20 >> Someday it would be nice if we could have one standard / libraritized >> set of functions that properly handle overflow and all that good = stuff >> (as bde has suggested to me elsewhere), but this is good enough for >> today. >=20 > strtonum(3)? bde said (back in 11/15): "It is good to fix the blind truncation, but overflow is never graceful. I will review the patch for errors like the ones in corresponding user code (dd get_num(), strtonum(), expand_number()... get_num() is almost OK, but the newer more public APIs are broken as designed)." So there's some concern that he has with those APIs still.. the = fact that I was trying to use a similar API to parse numbers in strings = in the kernel (strtoq in tunable work) didn't make things any better = unfortunately. Thanks, -Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?004687DF-47EF-4468-97DB-8443A249BE00>